Page MenuHomePhabricator

[native] Update `threadStore` with `threadStoreOps` in `fixUnreadActiveThread`
ClosedPublic

Authored by atul on Jun 2 2022, 1:01 PM.
Tags
None
Referenced Files
Unknown Object (File)
Thu, Nov 7, 11:13 PM
Unknown Object (File)
Sat, Nov 2, 3:14 PM
Unknown Object (File)
Oct 23 2024, 6:19 PM
Unknown Object (File)
Oct 9 2024, 3:11 AM
Unknown Object (File)
Oct 9 2024, 3:11 AM
Unknown Object (File)
Oct 8 2024, 8:54 AM
Unknown Object (File)
Oct 8 2024, 8:54 AM
Unknown Object (File)
Oct 8 2024, 8:54 AM

Details

Summary

Based on months with assertThreadStoreThreadsAreEqual enabled on staff builds, I think it's safe to conclude that processing the threadStore with the threadStoreOps leads to an equivalent result. There's no need to create an updatedThreadStore twice, so we're removing the non-ops approach.


Depends on D4193

Test Plan

assertThreadStoreThreadsAreEqual hasn't flagged anything since it's been included in staff builds

Diff Detail

Repository
rCOMM Comm
Lint
Lint Not Applicable
Unit
Tests Not Applicable