[lib] Remove `assertThreadStoreThreadsAreEqual` from `thread-reducer`
ClosedPublic
Actions

Authored by atul on Jun 2 2022, 8:37 PM.

Details

Reviewers

• jacek
tomek

Commits

rCOMM25aac7e2eb20: [lib] Remove `assertThreadStoreThreadsAreEqual` from `thread-reducer`

Summary

We removed the non-ops approaches of updating the threadStore, so there aren't any more usages of assertThreadStoreThreadsAreEqual in the codebase.

Depends on D4194

Test Plan

Searched codebase for "assertThreadStoreThreadsAreEqual" and found no occurences.

Diff Detail

Repository

rCOMM Comm

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

atul created this revision.Jun 2 2022, 8:37 PM

Herald added subscribers: • abosh, • adrian, ashoat. · View Herald TranscriptJun 2 2022, 8:37 PM

atul edited the summary of this revision. (Show Details)Jun 2 2022, 8:37 PM

Harbormaster completed remote builds in B9600: Diff 13310.Jun 2 2022, 8:44 PM

atul requested review of this revision.Jun 2 2022, 8:44 PM

atul edited the summary of this revision. (Show Details)Jun 3 2022, 12:22 AM

atul added a parent revision: D4194: [native] Update `threadStore` with `threadStoreOps` in `fixUnreadActiveThread`.

atul added a child revision: D4196: [lib] Get rid of `emptyArray` in `thread-reducer`.

tomek accepted this revision.Jun 3 2022, 9:37 AM

This revision is now accepted and ready to land.Jun 3 2022, 9:37 AM

cherrypick before landing

This revision was landed with ongoing or failed builds.Jun 8 2022, 9:07 AM

Closed by commit rCOMM25aac7e2eb20: [lib] Remove `assertThreadStoreThreadsAreEqual` from `thread-reducer`. · Explain Why

This revision was automatically updated to reflect the committed changes.

atul added a commit: rCOMM25aac7e2eb20: [lib] Remove `assertThreadStoreThreadsAreEqual` from `thread-reducer`.

Harbormaster completed remote builds in B9683: Diff 13418.Jun 8 2022, 9:08 AM

Revision Contents
Changeset List

Path

Size

lib/

reducers/

thread-reducer.js

25 lines

Diff 13419

View Options

lib/reducers/thread-reducer.js

[lib] Remove `assertThreadStoreThreadsAreEqual` from `thread-reducer`ClosedPublicActions