Paths

Table of Contentst

Differential D4215

[keyserver] Buildkite CI for Docker keyserver
ClosedPublic
Actions

Authored by ashoat on Jun 6 2022, 2:02 AM.

Details

Reviewers

atul

Commits

rCOMMc8c24a60c879: [keyserver] Buildkite CI for Docker keyserver

Summary

Linear task: ENG-997

Test Plan

This diff is actually the test!

Diff Detail

Repository

rCOMM Comm

Branch

ashoat/dockerize_node

Lint

No Lint Coverage

Unit

No Test Coverage

Event Timeline

ashoat created this revision.Jun 6 2022, 2:02 AM

Herald added subscribers: • abosh, • adrian, tomek. · View Herald TranscriptJun 6 2022, 2:02 AM

Harbormaster completed remote builds in B9630: Diff 13346.Jun 6 2022, 2:07 AM

ashoat requested review of this revision.Jun 6 2022, 2:07 AM

Need a Harbormaster config to test this, but I can't access credential K2

From CI machine:

open /home/atul/.buildkite-agent/builds/ci-spring-1/comm/docker-keyserver/keyserver/.env: no such file or directory

From local machine:

atul@atuls-MacBook-Pro comm % cd keyserver && bash/dc.sh build --no-cache
WARN[0000] The "COMM_MYSQL_DATABASE" variable is not set. Defaulting to a blank string. 
WARN[0000] The "COMM_MYSQL_USER" variable is not set. Defaulting to a blank string. 
WARN[0000] The "COMM_MYSQL_PASSWORD" variable is not set. Defaulting to a blank string. 
open /Users/atul/comm/keyserver/.env: no such file or directory

However, after creating an empty .env file in keyserver things worked as expected.

Didn't spend time investigating the root cause, but guessing it's because the env_file is specified as .env in keyserver/docker-compose.yml and it expects the file to exist? Maybe we could include a placeholder .env in the repo and .gitignore it (which we're actually already doing)?

I'd rather avoid the placeholder... I think it's weird to have files included in the repo but in the .gitignore. Just putting a touch command in there makes sense to me, I'll update the diff

ashoat added inline comments.Jun 7 2022, 1:39 PM

.buildkite/docker_keyserver.yml
3	Separately, seems like maybe I should disable the `--no-cache` here? Given we don't do it for other Docker builds, and Buildkite runners are a scarce resource

atul added inline comments.Jun 7 2022, 1:59 PM

.buildkite/docker_keyserver.yml
3	I think `—no-cache` for this is actually fine since it only took ~4 minutes (https://buildkite.com/comm/docker-keyserver/builds/6) whereas the services builds took ~33min from scratch earlier today (https://buildkite.com/comm/services-ci/builds/2756)

Add touch .env

Okay, left --no-cache in

Harbormaster completed remote builds in B9675: Diff 13404.Jun 7 2022, 3:15 PM

Triggering build again in hopes that it will show up in Phabricator

Woohoo it worked!! After this lands, I just need to update https://buildkite.com/comm/docker-keyserver/steps to:

steps:
  - command: 'buildkite-agent pipeline upload .buildkite/docker_keyserver.yml'

Harbormaster completed remote builds in B9676: Diff 13405.Jun 7 2022, 3:23 PM

atul accepted this revision.Jun 8 2022, 1:14 AM

This revision is now accepted and ready to land.Jun 8 2022, 1:14 AM

Closed by commit rCOMMc8c24a60c879: [keyserver] Buildkite CI for Docker keyserver (authored by ashoat). · Explain WhyJun 8 2022, 2:11 AM

This revision was automatically updated to reflect the committed changes.

ashoat added a commit: rCOMMc8c24a60c879: [keyserver] Buildkite CI for Docker keyserver.

In D4215#119299, @ashoat wrote:
Woohoo it worked!! After this lands, I just need to update https://buildkite.com/comm/docker-keyserver/steps to:
steps:
  - command: 'buildkite-agent pipeline upload .buildkite/docker_keyserver.yml'

Done

Revision Contents
Changeset List

Path

Size

.buildkite/

docker_keyserver.yml

5 lines

Diff 13346

View Options

.buildkite/docker_keyserver.yml

[keyserver] Buildkite CI for Docker keyserverClosedPublicActions