This diff introduces a flag to control whether we want to update thread unread status in persisted storage in reponse to notif rescind. Additionally it introduces threadID to iOS rescind, since we will need that in further diffs thath update unread status.
Details
Details
No test plan. Further differentials will use thos features and provide appropriate test plans.
Diff Detail
Diff Detail
- Repository
- rCOMM Comm
- Lint
No Lint Coverage - Unit
No Test Coverage
Event Timeline
| keyserver/src/push/rescind.js | ||
|---|---|---|
| 183 | I think on iOS we can simply use the boolean true (but not on Android, for some reason) | |
| keyserver/src/push/rescind.js | ||
|---|---|---|
| 62 ↗ | (On Diff #13424) | It's not necessary to send it for old iOS because the old client doesn't understand what threadID means. On the other hand, prepareIOSNotification doesn't include it for older clients, so keeping it is also fine, but less obvious. |
| 183 | Android receives a notification data as Map<String, String> and does not convert the values in any way - that's why it's required to send strings. | |