What I did in the past for the iOS/Android build workflows--which required a lot of iteration--was to fork the repo and run the actions there.
It might be overkill for this workflow which seems like it should be good to go... I'd argue that we should just land it and see what happens when it first runs?

@atul any reason we're using such an old version of Ubuntu?

I don't remember the exact details. I think it had to do with the Android build CI and some limitations of the pre-configured runners on 20.04? I'll put up a diff changing them all to ubuntu-latest and we can see what happens.

atul accepted this revision.Jun 8 2022, 1:18 AM

This revision is now accepted and ready to land.Jun 8 2022, 1:18 AM

Closed by commit rCOMM6576a659bdf2: [keyserver] GitHub Actions CI for Docker keyserver (authored by ashoat). · Explain WhyJun 8 2022, 2:11 AM

This revision was automatically updated to reflect the committed changes.

ashoat added a commit: rCOMM6576a659bdf2: [keyserver] GitHub Actions CI for Docker keyserver.

Looks like it worked: https://github.com/CommE2E/comm/runs/6790455410?check_suite_focus=true

Awesome!

atul mentioned this in D4261: [CI] Bump GitHub Actions Ubuntu machines to `ubuntu-latest`.Jun 14 2022, 10:11 AM

atul mentioned this in rCOMMfc9bd07a7c3e: [CI] Bump GitHub Actions Ubuntu machines to `ubuntu-latest`.Jun 14 2022, 11:17 AM

• abosh mentioned this in D4755: [CI] Add `ShellCheck` workflow to GitHub Actions.Aug 5 2022, 9:06 AM

• abosh mentioned this in rCOMM1401617c7e61: [CI] Add `ShellCheck` workflow to GitHub Actions.Aug 5 2022, 11:35 AM

• abosh mentioned this in rCOMM457673c23028: [CI] Add `ShellCheck` workflow to GitHub Actions.Aug 5 2022, 11:54 AM