Page MenuHomePhabricator

[docs] Replace `wget` command in gRPC docs with `curl`
ClosedPublic

Authored by abosh on Jun 14 2022, 8:01 AM.
Tags
None
Referenced Files
Unknown Object (File)
Sat, Nov 2, 1:15 PM
Unknown Object (File)
Sat, Nov 2, 1:15 PM
Unknown Object (File)
Sat, Nov 2, 1:12 PM
Unknown Object (File)
Sat, Nov 2, 12:41 PM
Unknown Object (File)
Oct 13 2024, 3:00 AM
Unknown Object (File)
Oct 8 2024, 3:46 AM
Unknown Object (File)
Oct 5 2024, 9:38 PM
Unknown Object (File)
Sep 29 2024, 11:23 PM

Details

Summary

Linear issue with full context here. The current gRPC docs make use of the wget command to install protobuf from GitHub, but wget is not pre-installed on macOS.

Replaced wget with curl, which is guaranteed to be installed since the brew install command above the wget command installs curl:

image.png (328×2 px, 240 KB)

Test Plan

Re-ran all the commands before and after the wget command in the comm home directory with the new curl command, made sure outputs were the same as with the wget command.

Diff Detail

Repository
rCOMM Comm
Branch
master
Lint
No Lint Coverage
Unit
No Test Coverage

Event Timeline

abosh edited the test plan for this revision. (Show Details)
abosh added inline comments.
docs/dev_environment.md
311

Why do we need the -L flag?

See this StackOverflow post.

docs/dev_environment.md
311

Why do we need the --output flag?

When run without the --output flag, curl exits with an error:
{F73892}

This revision is now accepted and ready to land.Jun 14 2022, 3:49 PM