Page MenuHomePhabricator
Differential D4332

[lib] Replace `mergedStore.messages` with `processedStore.messages` in `mergeNewMessages`
ClosedPublic
Actions

Authored by atul on Jun 22 2022, 2:50 PM.
Tags
None
Referenced Files
F2211297: D4332.id13687.diff
Mon, Jul 8, 1:46 AM
Unknown Object (File)
Sat, Jul 6, 7:15 PM
Unknown Object (File)
Sat, Jul 6, 7:15 PM
Unknown Object (File)
Sat, Jul 6, 10:58 AM
Unknown Object (File)
Sat, Jul 6, 10:58 AM
Unknown Object (File)
Sat, Jul 6, 10:58 AM
Unknown Object (File)
Wed, Jul 3, 12:04 PM
Unknown Object (File)
Wed, Jul 3, 5:55 AM
View All Files
Subscribers
• adrian
ashoat

Details

Reviewers
• jacek
tomek
• abosh
Commits
rCOMMbd034f550909: [lib] Replace `mergedStore.messages` with `processedStore.messages` in…
Summary

This diff removes the second-to-last usage of assertMessageStoreMessagesAreEqual(...) in message-reducer. The last usage is also in mergeNewMessages, but the logic there is more involved so I'm going to take a second to read through it again and put up a seperate diff.

Depends on D4331

Test Plan

This should be a straightforward refactor given we've had assertMessageStoreMessagesAreEqual in place for some time now.

Diff Detail

Repository
rCOMM Comm
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Revision Contents
Changeset List

PathSize
lib/
reducers/
15 lines

Diff 13749

View Options

lib/reducers/message-reducer.js

Loading...