Page MenuHomePhabricator

[lib] Remove `assertMessageStoreMessagesAreEqual(...)` from `message-reducer`
ClosedPublic

Authored by atul on Jun 22 2022, 3:02 PM.
Tags
None
Referenced Files
Unknown Object (File)
Sat, Jul 6, 7:16 PM
Unknown Object (File)
Sat, Jul 6, 7:15 PM
Unknown Object (File)
Sat, Jul 6, 7:15 PM
Unknown Object (File)
Sat, Jul 6, 7:15 PM
Unknown Object (File)
Sat, Jul 6, 10:58 AM
Unknown Object (File)
Sat, Jul 6, 12:56 AM
Unknown Object (File)
Fri, Jul 5, 3:24 AM
Unknown Object (File)
Thu, Jul 4, 7:00 PM
Subscribers

Details

Summary

We no longer need to assert that the "old approach" and the "ops approach" are equal... because we're removing the "old approach" altogether.

This diff

  • removes the last usage of assertMessageStoreMessagesAreEqual from mergeNewMessages
  • removes assertMessageStoreMessagesAreEqual
  • removes imports that assertMessageStoreMessagesAreEqual depended on
  • removes actionType argument from mergeNewMessages(..._) since it was only used by assertMessageStoreMessagesAreEqual from within mergeNewMessages

Depends on D4332

Test Plan

This should be a straightforward refactor given we've had assertMessageStoreMessagesAreEqual in place for some time now.

Diff Detail

Repository
rCOMM Comm
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

atul requested review of this revision.Jun 22 2022, 3:07 PM
This revision is now accepted and ready to land.Jun 23 2022, 3:58 AM

rebase after cherrypicking and before landing