Page MenuHomePhabricator
Differential D7397

[lib] restore function for asserting store after performing ops
ClosedPublic
Actions

Authored by kamil on Apr 12 2023, 9:51 AM.
Tags
None
Referenced Files
F3253596: D7397.id25100.diff
Fri, Nov 15, 7:14 PM
F3252123: D7397.diff
Fri, Nov 15, 6:05 PM
Unknown Object (File)
Fri, Nov 8, 2:46 PM
Unknown Object (File)
Fri, Nov 8, 2:46 PM
Unknown Object (File)
Fri, Nov 8, 2:46 PM
Unknown Object (File)
Fri, Nov 8, 2:46 PM
Unknown Object (File)
Fri, Nov 8, 2:46 PM
Unknown Object (File)
Fri, Nov 8, 2:42 PM
View All Files
Subscribers
ashoat
atul

Details

Reviewers
tomek
marcin
Commits
rCOMM543ffeb69feb: [lib] restore function for asserting store after performing ops
Summary

Reusing code removed in D4333 to check if operations works properly.

Depends on D7396

Test Plan

On native warnings will pop up

image.png (249×411 px, 61 KB)

on web errors in console

image.png (186×875 px, 66 KB)

Diff Detail

Repository
rCOMM Comm
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

kamil created this revision.Apr 12 2023, 9:51 AM
kamil held this revision as a draft.
Herald added subscribers: atul, ashoat. · View Herald TranscriptApr 12 2023, 9:51 AM
kamil added a child revision: D7398: [lib] generate message store ops for threads while merging messages.Apr 12 2023, 9:56 AM
Harbormaster failed remote builds in B18274: Diff 25046!Apr 12 2023, 10:04 AM
kamil updated this revision to Diff 25100.Apr 13 2023, 7:23 AM

rebase

kamil edited the test plan for this revision. (Show Details)Apr 13 2023, 7:32 AM
Harbormaster completed remote builds in B18318: Diff 25100.Apr 13 2023, 7:41 AM
kamil published this revision for review.Apr 13 2023, 8:18 AM
kamil added inline comments.
lib/reducers/message-reducer.js
139 ↗(On Diff #25100)

this comment will be removed in the next diff in the stack - logic is really complicated there so I preferred to separate this to make it easier for reviewers, and without this eslint will fail

tomek accepted this revision.Apr 14 2023, 4:58 AM
This revision is now accepted and ready to land.Apr 14 2023, 4:58 AM
kamil updated this revision to Diff 25344.Apr 19 2023, 9:01 AM

rebase before landing

Harbormaster completed remote builds in B18507: Diff 25344.Apr 19 2023, 9:20 AM
Closed by commit rCOMM543ffeb69feb: [lib] restore function for asserting store after performing ops (authored by kamil). · Explain WhyApr 19 2023, 10:28 AM
This revision was automatically updated to reflect the committed changes.
kamil added a commit: rCOMM543ffeb69feb: [lib] restore function for asserting store after performing ops.

Revision Contents
Changeset List

PathSize
lib/
reducers/
20 lines

Diff 25367

View Options

lib/reducers/message-reducer.js

Loading...