Page MenuHomePhabricator
Differential D7412

[lib] generate message store ops for threads on reaction failure
ClosedPublic
Actions

Authored by kamil on Apr 13 2023, 1:13 AM.
Tags
None
Referenced Files
Unknown Object (File)
Thu, Sep 26, 11:45 AM
Unknown Object (File)
Fri, Sep 20, 5:00 PM
Unknown Object (File)
Mon, Sep 16, 3:24 AM
Unknown Object (File)
Sat, Sep 7, 1:41 AM
Unknown Object (File)
Sat, Sep 7, 1:41 AM
Unknown Object (File)
Sat, Sep 7, 1:41 AM
Unknown Object (File)
Sat, Sep 7, 1:41 AM
Unknown Object (File)
Sat, Sep 7, 1:40 AM
View All Files
Subscribers
ashoat
atul

Details

Reviewers
tomek
marcin
Commits
rCOMMd656ac8e8e85: [lib] generate message store ops for threads on reaction failure
Summary

This code generates operations need for updating threads part of message store after sendReactionMessageActionTypes.failed

Depends on D7410

Test Plan

Kill keyserver and try to react

Diff Detail

Repository
rCOMM Comm
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

kamil created this revision.Apr 13 2023, 1:13 AM
kamil held this revision as a draft.
Herald added subscribers: atul, ashoat. · View Herald TranscriptApr 13 2023, 1:13 AM
Harbormaster failed remote builds in B18302: Diff 25080!Apr 13 2023, 1:26 AM
kamil updated this revision to Diff 25104.Apr 13 2023, 7:30 AM

rebase

kamil added a child revision: D7417: [lib] generate message store ops for threads while starting to send a message.Apr 13 2023, 7:30 AM
Harbormaster completed remote builds in B18321: Diff 25104.Apr 13 2023, 7:47 AM
kamil published this revision for review.Apr 13 2023, 8:26 AM
tomek requested changes to this revision.Apr 14 2023, 5:56 AM
tomek added inline comments.
lib/reducers/message-reducer.js
1130–1135 ↗(On Diff #25104)

If I remember correctly, we're not persisting messageIDs of threads. Is it going to change?

This revision now requires changes to proceed.Apr 14 2023, 5:56 AM
kamil requested review of this revision.Apr 18 2023, 5:52 AM
kamil added inline comments.
lib/reducers/message-reducer.js
1130–1135 ↗(On Diff #25104)

operations are not only for database - entire logic should be based on operations (updating in-memory redux state), that's why we generate operations also for updating messageIDs. And then, we will convert those to database ops by excluding messageIDs that will not be persisted.

tomek accepted this revision.Apr 19 2023, 1:33 AM
This revision is now accepted and ready to land.Apr 19 2023, 1:33 AM
kamil updated this revision to Diff 25347.Apr 19 2023, 9:11 AM

rebase before landing

Harbormaster completed remote builds in B18510: Diff 25347.Apr 19 2023, 9:30 AM
Closed by commit rCOMMd656ac8e8e85: [lib] generate message store ops for threads on reaction failure (authored by kamil). · Explain WhyApr 19 2023, 10:29 AM
This revision was automatically updated to reflect the committed changes.
kamil added a commit: rCOMMd656ac8e8e85: [lib] generate message store ops for threads on reaction failure.

Revision Contents
Changeset List

PathSize
lib/
reducers/
36 lines

Diff 25369

View Options

lib/reducers/message-reducer.js

Loading...