[lib] generate message store ops for threads after pruning messages
ClosedPublic
Actions

Authored by kamil on Apr 13 2023, 7:37 AM.

Details

Reviewers

tomek
marcin

Commits

rCOMM9b6134cc78e7: [lib] generate message store ops for threads after pruning messages

Summary

This code generates operations needed for updating threads part of message store after pruning messages.

Depends on D7419

Test Plan

Force app to prune messages (eg. modify msInHour) and check asserting

Diff Detail

Repository

rCOMM Comm

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

kamil created this revision.Apr 13 2023, 7:37 AM

kamil held this revision as a draft.

Herald added subscribers: atul, ashoat. · View Herald TranscriptApr 13 2023, 7:37 AM

Harbormaster completed remote builds in B18325: Diff 25109.Apr 13 2023, 7:55 AM

kamil published this revision for review.Apr 13 2023, 8:31 AM

tomek accepted this revision.Apr 17 2023, 5:45 AM

tomek added inline comments.

lib/reducers/message-reducer.js
1344 ↗	(On Diff #25109)

This revision is now accepted and ready to land.Apr 17 2023, 5:45 AM

remove spreading

Harbormaster completed remote builds in B18517: Diff 25362.Apr 19 2023, 9:53 AM

Closed by commit rCOMM9b6134cc78e7: [lib] generate message store ops for threads after pruning messages (authored by kamil). · Explain WhyApr 19 2023, 10:29 AM

This revision was automatically updated to reflect the committed changes.

kamil added a commit: rCOMM9b6134cc78e7: [lib] generate message store ops for threads after pruning messages.

Revision Contents
Changeset List

Path

Size

lib/

reducers/

message-reducer.js

36 lines

Diff 25373

View Options

lib/reducers/message-reducer.js

This file was added.

				// @flow

				import * as React from 'react';

				import type { UserListItem } from 'lib/types/user-types';

				import AddMembersItem from './add-members-item.react';
				import css from './members-modal.css';

				type AddMemberItemGroupProps = {
				+header: string,
				+userInfos: $ReadOnlyArray<UserListItem>,
				+onUserClick: (userID: string) => void,
				+usersAdded: $ReadOnlySet<string>,
				};
				function AddMembersItemGroup(props: AddMemberItemGroupProps): React.Node {
				const { userInfos, onUserClick, usersAdded, header } = props;

				const sortedUserInfos = React.useMemo(() => {
				return [...userInfos].sort((a, b) => a.username.localeCompare(b.username));
				}, [userInfos]);

				const userInfosComponents = React.useMemo(
				() =>
				sortedUserInfos.map(userInfo => (
				<AddMembersItem
				key={userInfo.id}
				userInfo={userInfo}
				onClick={onUserClick}
				userAdded={usersAdded.has(userInfo.id)}
				/>
				)),
				[onUserClick, sortedUserInfos, usersAdded],
				);

				return (
				<>
				<div className={css.addMemberItemsGroupHeader}>{header}:</div>
				{userInfosComponents}
				</>
				);
				}

				export default AddMembersItemGroup;

[lib] generate message store ops for threads after pruning messagesClosedPublicActions