lib/reducers/message-reducer.js
205–215 ↗	(On Diff #25103)	It might be a little safer to change the order here. If we decide to use foreign keys in our db, we don't want for our new messages to be removed by cascade delete. Currently it doesn't change anything, but this ordering is less confusing.

This revision is now accepted and ready to land.Apr 14 2023, 5:46 AM

change ops order

lib/reducers/message-reducer.js
205–215 ↗	(On Diff #25103)	makes sense - updating

Harbormaster completed remote builds in B18509: Diff 25346.Apr 19 2023, 9:28 AM

Closed by commit rCOMM30191630a95d: [lib] generate message store ops for threads while creating fresh store (authored by kamil). · Explain WhyApr 19 2023, 10:28 AM

This revision was automatically updated to reflect the committed changes.

kamil added a commit: rCOMM30191630a95d: [lib] generate message store ops for threads while creating fresh store.

Revision Contents
Changeset List

Path

Size

lib/

reducers/

message-reducer.js

23 lines

Diff 25368

View Options

lib/reducers/message-reducer.js

Show First 20 Lines • Show All 1,023 Lines • ▼ Show 20 Lines	): ReduceMessageStoreResult {
) {		) {
const payload = ensureRealizedThreadIDIsUsedWhenPossible(		const payload = ensureRealizedThreadIDIsUsedWhenPossible(
action.payload,		action.payload,
newThreadInfos,		newThreadInfos,
);		);
const { localID, threadID } = payload;		const { localID, threadID } = payload;
invariant(localID, `localID should be set on ${action.type}`);		invariant(localID, `localID should be set on ${action.type}`);

		const messageIDs = messageStore.threads[threadID]?.messageIDs ?? [];
		if (!messageStore.messages[localID]) {
		for (const existingMessageID of messageIDs) {
		const existingMessageInfo = messageStore.messages[existingMessageID];
		if (existingMessageInfo && existingMessageInfo.localID === localID) {
		return { messageStoreOperations: [], messageStore };
		}
		}
		}

const messageStoreOperations = [		const messageStoreOperations = [
{		{
type: 'replace',		type: 'replace',
payload: { id: localID, messageInfo: payload },		payload: { id: localID, messageInfo: payload },
},		},
];		];
const processedMessageStore = processMessageStoreOperations(
messageStore,
messageStoreOperations,
);

const now = Date.now();		const now = Date.now();
const messageIDs = messageStore.threads[threadID]?.messageIDs ?? [];		let updatedThreads;
		let local = { ...messageStore.local };
if (messageStore.messages[localID]) {		if (messageStore.messages[localID]) {
const messages = { ...messageStore.messages, [localID]: payload };		const messages = { ...messageStore.messages, [localID]: payload };
const local = _pickBy(		local = _pickBy(
(localInfo: LocalMessageInfo, key: string) => key !== localID,		(localInfo: LocalMessageInfo, key: string) => key !== localID,
)(messageStore.local);		)(messageStore.local);
const thread = messageStore.threads[threadID];		const thread = messageStore.threads[threadID];
const threads = {		updatedThreads = {
...messageStore.threads,
[threadID]: {		[threadID]: {
messageIDs: sortMessageIDs(messages)(messageIDs),		messageIDs: sortMessageIDs(messages)(messageIDs),
startReached: thread?.startReached ?? true,		startReached: thread?.startReached ?? true,
lastNavigatedTo: thread?.lastNavigatedTo ?? now,		lastNavigatedTo: thread?.lastNavigatedTo ?? now,
lastPruned: thread?.lastPruned ?? now,		lastPruned: thread?.lastPruned ?? now,
},		},
};		};
return {		} else {
messageStoreOperations,		updatedThreads = {
messageStore: {		[threadID]: messageStore.threads[threadID]
...messageStore,
messages: processedMessageStore.messages,
threads,
local,
},
};
}

for (const existingMessageID of messageIDs) {
const existingMessageInfo = messageStore.messages[existingMessageID];
if (existingMessageInfo && existingMessageInfo.localID === localID) {
return { messageStoreOperations: [], messageStore };
}
}

const threadState: ThreadMessageInfo = messageStore.threads[threadID]
? {		? {
...messageStore.threads[threadID],		...messageStore.threads[threadID],
messageIDs: [localID, ...messageIDs],		messageIDs: [localID, ...messageIDs],
}		}
: {		: {
messageIDs: [localID],		messageIDs: [localID],
startReached: true,		startReached: true,
lastNavigatedTo: now,		lastNavigatedTo: now,
lastPruned: now,		lastPruned: now,
		},
};		};
		}

return {		const threads = {
messageStoreOperations,
messageStore: {
messages: processedMessageStore.messages,
threads: {
...messageStore.threads,		...messageStore.threads,
[threadID]: threadState,		...updatedThreads,
		};
		messageStoreOperations.push({
		type: 'replace_threads',
		payload: {
		threads: { ...updatedThreads },
},		},
local: messageStore.local,		});

		const processedMessageStore = processMessageStoreOperations(
		messageStore,
		messageStoreOperations,
		);

		const newMessageStore = {
		messages: processedMessageStore.messages,
		threads,
		local,
currentAsOf: messageStore.currentAsOf,		currentAsOf: messageStore.currentAsOf,
},		};

		assertMessageStoreThreadsAreEqual(
		processedMessageStore,
		newMessageStore,
		action.type,
		);

		return {
		messageStoreOperations,
		messageStore: newMessageStore,
};		};
} else if (		} else if (
action.type === sendTextMessageActionTypes.failed \|\|		action.type === sendTextMessageActionTypes.failed \|\|
action.type === sendMultimediaMessageActionTypes.failed		action.type === sendMultimediaMessageActionTypes.failed
) {		) {
const { localID } = action.payload;		const { localID } = action.payload;
return {		return {
messageStoreOperations: [],		messageStoreOperations: [],
▲ Show 20 Lines • Show All 565 Lines • Show Last 20 Lines

[lib] generate message store ops for threads while creating fresh storeClosedPublicActions

Details

Diff Detail

Event Timeline

Revision ContentsChangeset List

Diff 25368

lib/reducers/message-reducer.js

[lib] generate message store ops for threads while creating fresh store
ClosedPublic
Actions

Revision Contents
Changeset List