Page MenuHomePhabricator
Differential D7410

[lib] generate message store ops for threads while creating fresh store
ClosedPublic
Actions

Authored by kamil on Apr 13 2023, 1:03 AM.
Tags
None
Referenced Files
F3260460: D7410.diff
Fri, Nov 15, 10:38 PM
Unknown Object (File)
Fri, Nov 8, 2:46 PM
Unknown Object (File)
Fri, Nov 8, 2:46 PM
Unknown Object (File)
Fri, Nov 8, 2:46 PM
Unknown Object (File)
Fri, Nov 8, 2:46 PM
Unknown Object (File)
Fri, Nov 8, 2:46 PM
Unknown Object (File)
Fri, Nov 8, 2:42 PM
Unknown Object (File)
Tue, Nov 5, 4:18 AM
View All Files
Subscribers
ashoat
atul

Details

Reviewers
tomek
marcin
Commits
rCOMM30191630a95d: [lib] generate message store ops for threads while creating fresh store
Summary

This code generates operations need for creating fresh threads.

Depends on D7398

Test Plan

Log in/out multiple times on bot web and native nad check for warning in console.

Diff Detail

Repository
rCOMM Comm
Lint
No Lint Coverage
Unit
No Test Coverage

Event Timeline

kamil created this revision.Apr 13 2023, 1:03 AM
kamil held this revision as a draft.
Herald added subscribers: atul, ashoat. · View Herald TranscriptApr 13 2023, 1:03 AM
kamil added a child revision: D7412: [lib] generate message store ops for threads on reaction failure.Apr 13 2023, 1:13 AM
Harbormaster completed remote builds in B18300: Diff 25078.Apr 13 2023, 1:21 AM
kamil updated this revision to Diff 25103.Apr 13 2023, 7:28 AM

rebase

Harbormaster completed remote builds in B18320: Diff 25103.Apr 13 2023, 7:47 AM
kamil published this revision for review.Apr 13 2023, 8:25 AM
tomek accepted this revision.Apr 14 2023, 5:46 AM
tomek added inline comments.
lib/reducers/message-reducer.js
205–215

It might be a little safer to change the order here. If we decide to use foreign keys in our db, we don't want for our new messages to be removed by cascade delete. Currently it doesn't change anything, but this ordering is less confusing.

This revision is now accepted and ready to land.Apr 14 2023, 5:46 AM
kamil updated this revision to Diff 25346.Apr 19 2023, 9:10 AM

change ops order

lib/reducers/message-reducer.js
205–215

makes sense - updating

Harbormaster completed remote builds in B18509: Diff 25346.Apr 19 2023, 9:28 AM
Closed by commit rCOMM30191630a95d: [lib] generate message store ops for threads while creating fresh store (authored by kamil). · Explain WhyApr 19 2023, 10:28 AM
This revision was automatically updated to reflect the committed changes.
kamil added a commit: rCOMM30191630a95d: [lib] generate message store ops for threads while creating fresh store.

Revision Contents
Changeset List

PathSize
lib/
reducers/
23 lines

Diff 25103

View Options

lib/reducers/message-reducer.js

Loading...