Page MenuHomePhabricator

Summary: added boilerplate for SIWE
AbandonedPublic

Authored by derek on Jun 23 2022, 2:11 PM.
Tags
None
Referenced Files
F3113738: D4349.diff
Thu, Oct 31, 6:33 PM
Unknown Object (File)
Mon, Oct 28, 5:07 AM
Unknown Object (File)
Mon, Oct 28, 5:05 AM
Unknown Object (File)
Fri, Oct 18, 5:08 PM
Unknown Object (File)
Sun, Oct 6, 1:10 PM
Unknown Object (File)
Thu, Oct 3, 4:56 PM
Unknown Object (File)
Sep 17 2024, 12:09 AM
Unknown Object (File)
Sep 16 2024, 2:22 PM

Details

Test Plan

keep iterating on SIWE

Diff Detail

Repository
rCOMM Comm
Branch
derek/siwe-phab
Lint
No Lint Coverage
Unit
No Test Coverage

Event Timeline

ashoat requested changes to this revision.Jun 28 2022, 9:40 AM
ashoat added reviewers: varun, atul, tomek.
ashoat added a subscriber: varun.
  1. There are no reviewers on this... you should always make sure to specify some reviewers! I'll add @varun, @atul, @palys-swm for now, as well as myself since you're changing dependencies (see full list of situations where you should add me to a diff here)
  2. Is this diff ready for review? Seems a bit like a draft with the commented-out code, and the additional context from chat that we're reconsidering using RainbowKit from within a webview (correct me if I'm wrong)

Requesting changes to get an answer to question 2 above!

landing/root.js
9

Generally we should avoid putting up diffs up with commented-out code

This revision now requires changes to proceed.Jun 28 2022, 9:40 AM

You also need a real test plan