keep iterating on SIWE
Diff Detail
Diff Detail
- Repository
- rCOMM Comm
- Branch
- derek/siwe-phab
- Lint
No Lint Coverage - Unit
No Test Coverage
Event Timeline
Comment Actions
- There are no reviewers on this... you should always make sure to specify some reviewers! I'll add @varun, @atul, @palys-swm for now, as well as myself since you're changing dependencies (see full list of situations where you should add me to a diff here)
- Is this diff ready for review? Seems a bit like a draft with the commented-out code, and the additional context from chat that we're reconsidering using RainbowKit from within a webview (correct me if I'm wrong)
Requesting changes to get an answer to question 2 above!
landing/root.js | ||
---|---|---|
9 | Generally we should avoid putting up diffs up with commented-out code |