Paths

Table of Contentst

Differential D4351

[services][identity] helper function to finish PAKE login
ClosedPublic
Actions

Authored by varun on Jun 24 2022, 6:33 AM.

Tags

None

Referenced Files

	Unknown Object (File)
	Wed, Nov 13, 2:08 AM

	Unknown Object (File)
	Wed, Nov 13, 2:08 AM

	Unknown Object (File)
	Wed, Nov 13, 2:08 AM

	Unknown Object (File)
	Wed, Nov 13, 2:08 AM

	Unknown Object (File)
	Wed, Nov 13, 2:05 AM

	Unknown Object (File)
	Oct 23 2024, 6:44 AM

	Unknown Object (File)
	Oct 22 2024, 2:40 AM

	Unknown Object (File)
	Oct 21 2024, 1:47 AM

Subscribers

Details

Reviewers

tomek
• jim
• karol

Commits

rCOMMfe72ec70f739: [services][identity] helper function to finish PAKE login

Summary

helper function completes PAKE login and returns an access token or an error depending on the outcome

depends on D4350

Test Plan

tested with method that calls this helper

Diff Detail

Repository

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

varun created this revision.Jun 24 2022, 6:33 AM

Herald added subscribers: • abosh, atul, • adrian, ashoat. · View Herald TranscriptJun 24 2022, 6:33 AM

varun added a child revision: D4352: [services][identity] PAKE login.Jun 24 2022, 6:36 AM

Harbormaster completed remote builds in B9947: Diff 13758.Jun 24 2022, 6:39 AM

varun requested review of this revision.Jun 24 2022, 6:39 AM

varun added 1 blocking reviewer(s): • jim.Jun 24 2022, 8:31 AM

rebase

Harbormaster completed remote builds in B10000: Diff 13817.Jun 27 2022, 1:26 AM

tomek accepted this revision.Jun 27 2022, 4:09 AM

tomek added inline comments.

services/identity/src/service.rs
391 ↗	(On Diff #13817)	This is login or register, so it should be reflected in this message
391 ↗	(On Diff #13817)	Is it a good idea to ignore an error from `server_login`?

varun removed 1 blocking reviewer(s): • jim.Jun 28 2022, 6:44 AM

This revision is now accepted and ready to land.Jun 28 2022, 6:44 AM

varun added inline comments.Jun 28 2022, 6:48 AM

services/identity/src/service.rs
391 ↗	(On Diff #13817)	This is login or register, so it should be reflected in this message I'll add an error log that reflects this Is it a good idea to ignore an error from server_login? We don't ignore the error, the question mark operator means we return an error immediately if we encounter one. We should definitely log the error, though -- which I will do before landing this

Closed by commit rCOMMfe72ec70f739: [services][identity] helper function to finish PAKE login (authored by varun). · Explain WhyJun 28 2022, 7:12 AM

This revision was automatically updated to reflect the committed changes.

varun added a commit: rCOMMfe72ec70f739: [services][identity] helper function to finish PAKE login.

Revision Contents
Changeset List

Path

Size

services/

identity/

src/

54 lines

Diff 13896

services/identity/src/service.rs

Loading...