Details
Running yarn run-[service-name]-service-in-sandbox do the same as previous yarn run-[service-name]-service-dev-mode
Diff Detail
- Repository
- rCOMM Comm
- Lint
Lint Not Applicable - Unit
Tests Not Applicable
Event Timeline
@ashoat's comment suggests to avoid dev-mode and use dev mode instead.
In other place @ashoat suggests to explain what a dev mode is https://phab.comm.dev/D4253#inline-26680
So it doesn't look like @ashoat's intention is to replace dev mode with sandbox.
On the other hand @varun suggests that we should change the commands to use sandbox in names.
So there's no place where someone suggests to change something more than just the commands. And it doesn't seem like there's an agreement regarding changing to sandbox.
Adding both @ashoat and @varun as blocking to clarify what's the goal here.
In my opinion, keeping dev mode is ok, but we need to clarify in the documentation what it means for us. The explanation of sandbox should also be included if we decide to rename. I'm not sure if sandbox is a better name, because dev mode not only sandboxes the environment, but also might e.g. have different log levels.
I think the goal is clarity. With dev mode, there was confusion as to whether it was the only way to run/test services (it's not, since we can just run them with docker compose). I thought calling it a sandbox would make it clearer that it's a separate local environment. We could also call it a local cloud stack, which is the terminology LocalStack uses. That might be best, honestly.
All that being said, I don't feel too strongly about this, and am happy to defer to whatever you and @ashoat think
I've voted for sandbox too. Maybe we should vote or something for this change to make a consensus? Btw, @karol-bisztyga didn't post his comment yet.