Page MenuHomePhabricator
Differential D4369

[android] Convert `.png` assets to `.webp` assets
ClosedPublic
Actions

Authored by atul on Jun 27 2022, 4:57 PM.
Tags
None
Referenced Files
F2212380: D4369.diff
Mon, Jul 8, 6:54 AM
Unknown Object (File)
Sat, Jul 6, 11:58 PM
Unknown Object (File)
Fri, Jun 21, 7:11 PM
Unknown Object (File)
Fri, Jun 21, 7:10 PM
Unknown Object (File)
Fri, Jun 21, 6:52 PM
Unknown Object (File)
Wed, Jun 12, 10:08 AM
Unknown Object (File)
Apr 29 2024, 5:13 PM
Unknown Object (File)
Apr 20 2024, 12:02 AM
View All 54 Files
Subscribers
• adrian
ashoat

Details

Reviewers
• jacek
tomek
• abosh
Commits
rCOMM1c090e1f2359: [android] Convert `.png` assets to `.webp` assets
Summary

This conversion happens during the bundleRelease process and takes a bit of time. Might as well do it once and avoid whatever cost during buildtime.

(This was a "lossless" conversion)

Context: https://developer.android.com/studio/build/optimize-your-build#use_webp

Test Plan

Things continue to look as expected when launching app on Android emulator.

Diff Detail

Repository
rCOMM Comm
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

atul created this revision.Jun 27 2022, 4:57 PM
Herald added subscribers: • adrian, ashoat. · View Herald TranscriptJun 27 2022, 4:57 PM
atul mentioned this in D4370: [android] Convert `splash_background` JPEGs to WEBP.Jun 27 2022, 5:03 PM
Harbormaster completed remote builds in B10024: Diff 13863.Jun 27 2022, 5:06 PM
atul requested review of this revision.Jun 27 2022, 5:06 PM
atul edited the summary of this revision. (Show Details)Jun 27 2022, 5:07 PM
atul added a child revision: D4370: [android] Convert `splash_background` JPEGs to WEBP.
tomek accepted this revision.Jun 28 2022, 4:08 AM
This revision is now accepted and ready to land.Jun 28 2022, 4:08 AM
• abosh accepted this revision.Jun 28 2022, 10:06 AM
atul updated this revision to Diff 13916.Jun 28 2022, 5:57 PM

rebase after cherrypicking and before landing

Harbormaster completed remote builds in B10065: Diff 13916.Jun 28 2022, 6:08 PM
Closed by commit rCOMM1c090e1f2359: [android] Convert `.png` assets to `.webp` assets (authored by atul). · Explain WhyJun 28 2022, 8:35 PM
This revision was automatically updated to reflect the committed changes.
atul added a commit: rCOMM1c090e1f2359: [android] Convert `.png` assets to `.webp` assets.

Revision Contents
Changeset List

Diff 13917

View Options

native/android/app/src/main/res/drawable-hdpi/header.png

Loading...
View Options

native/android/app/src/main/res/drawable-hdpi/header.webp

Loading...
View Options

native/android/app/src/main/res/drawable-hdpi/notif_icon.png

Loading...
View Options

native/android/app/src/main/res/drawable-hdpi/notif_icon.webp

Loading...
View Options

native/android/app/src/main/res/drawable-xhdpi/header.png

Loading...
View Options

native/android/app/src/main/res/drawable-xhdpi/header.webp

Loading...
View Options

native/android/app/src/main/res/drawable-xhdpi/notif_icon.png

Loading...
View Options

native/android/app/src/main/res/drawable-xhdpi/notif_icon.webp

Loading...
View Options

native/android/app/src/main/res/drawable-xxhdpi/header.png

Loading...
View Options

native/android/app/src/main/res/drawable-xxhdpi/header.webp

Loading...
View Options

native/android/app/src/main/res/drawable-xxhdpi/notif_icon.png

Loading...
View Options

native/android/app/src/main/res/drawable-xxhdpi/notif_icon.webp

Loading...
View Options

native/android/app/src/main/res/drawable-xxxhdpi/header.png

Loading...
View Options

native/android/app/src/main/res/drawable-xxxhdpi/header.webp

Loading...
View Options

native/android/app/src/main/res/drawable-xxxhdpi/notif_icon.png

Loading...
View Options

native/android/app/src/main/res/drawable-xxxhdpi/notif_icon.webp

Loading...
View Options

native/android/app/src/main/res/drawable/header.png

Loading...
View Options

native/android/app/src/main/res/drawable/header.webp

Loading...
View Options

native/android/app/src/main/res/drawable/notif_icon.png

Loading...
View Options

native/android/app/src/main/res/drawable/notif_icon.webp

Loading...
View Options

native/android/app/src/main/res/mipmap-hdpi/ic_launcher_foreground.png

Loading...
View Options

native/android/app/src/main/res/mipmap-hdpi/ic_launcher_foreground.webp

Loading...
View Options

native/android/app/src/main/res/mipmap-mdpi/ic_launcher_foreground.png

Loading...
View Options

native/android/app/src/main/res/mipmap-mdpi/ic_launcher_foreground.webp

Loading...
View Options

native/android/app/src/main/res/mipmap-xhdpi/ic_launcher_foreground.png

Loading...
View Options

native/android/app/src/main/res/mipmap-xhdpi/ic_launcher_foreground.webp

Loading...
View Options

native/android/app/src/main/res/mipmap-xxhdpi/ic_launcher_foreground.png

Loading...
View Options

native/android/app/src/main/res/mipmap-xxhdpi/ic_launcher_foreground.webp

Loading...
View Options

native/android/app/src/main/res/mipmap-xxxhdpi/ic_launcher_foreground.png

Loading...
View Options

native/android/app/src/main/res/mipmap-xxxhdpi/ic_launcher_foreground.webp

Loading...