Page MenuHomePhabricator
Differential D4438

[services] Backup - pull attachment holders out of the data section
ClosedPublic
Actions

Authored by • karol on Jul 5 2022, 12:44 AM.
Tags
None
Referenced Files
F2211635: D4438.diff
Mon, Jul 8, 3:48 AM
F2210173: D4438.id14860.diff
Sun, Jul 7, 9:17 PM
Unknown Object (File)
Sat, Jul 6, 11:09 PM
Unknown Object (File)
Sat, Jul 6, 11:09 PM
Unknown Object (File)
Sat, Jul 6, 11:09 PM
Unknown Object (File)
Sat, Jul 6, 11:09 PM
Unknown Object (File)
Sat, Jul 6, 11:08 PM
Unknown Object (File)
Sat, Jul 6, 11:08 PM
View All Files
Subscribers
• abosh
• adrian
ashoat
atul
tomek

Details

Reviewers
tomek
ashoat
Commits
rCOMMb79230129dab: [services] Backup - pull attachment holders out of the data section
Summary

Raised in https://phab.comm.dev/D4245#124304

This change will reduce the cycles when sending the data with attachments

Test Plan

None for now, services will build, as usual, this field is optional so not setting it doesn't break anything.

Diff Detail

Repository
rCOMM Comm
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

• karol created this revision.Jul 5 2022, 12:44 AM
Herald added subscribers: • abosh, atul, • adrian and 2 others. · View Herald TranscriptJul 5 2022, 12:44 AM
Harbormaster returned this revision to the author for changes because remote builds failed.Jul 5 2022, 12:45 AM
Harbormaster failed remote builds in B10247: Diff 14139!
• karol requested review of this revision.Jul 5 2022, 1:01 AM
• karol edited the summary of this revision. (Show Details)
• karol edited the test plan for this revision. (Show Details)
• karol added reviewers: tomek, ashoat.
• karol added a parent revision: D4437: [services] Add reset local cloud command.

CI is broken

• karol added a child revision: D4439: [services] Blob - Add extra bytes needed to get request.Jul 5 2022, 1:13 AM
• karol mentioned this in D4442: [services] Tests - Backup - Adjust the logic.Jul 5 2022, 1:23 AM
• karol mentioned this in D4245: [services] Backup - Add current id and attachment holders.
ashoat requested changes to this revision.Jul 5 2022, 11:48 AM

I may be confused about something, but see my comment here

This revision now requires changes to proceed.Jul 5 2022, 11:48 AM
• karol requested review of this revision.Jul 6 2022, 2:50 AM

Responded in the linked diff. I think doing a follow-up is far less expensive for both sides and works a lot better.

ashoat requested changes to this revision.Jul 6 2022, 9:48 AM

See comment in D4245

This revision now requires changes to proceed.Jul 6 2022, 9:48 AM
• karol updated this revision to Diff 14354.Jul 8 2022, 2:31 AM
• karol edited the summary of this revision. (Show Details)

retrigger CI/request review

Harbormaster completed remote builds in B10413: Diff 14354.Jul 8 2022, 2:43 AM
ashoat accepted this revision.Jul 8 2022, 8:02 AM

Oops forgot to accept this yesterday, sorry

This revision is now accepted and ready to land.Jul 8 2022, 8:02 AM
• karol updated this revision to Diff 14571.Jul 18 2022, 6:59 AM

empty

• karol added a child revision: D4554: [services] Backup - send log - add case for DB.Jul 18 2022, 7:05 AM
Harbormaster completed remote builds in B10582: Diff 14571.Jul 18 2022, 7:13 AM
• karol edited the summary of this revision. (Show Details)Jul 19 2022, 2:05 AM
• karol removed a parent revision: D4437: [services] Add reset local cloud command.
• karol updated this revision to Diff 14851.Jul 25 2022, 6:59 AM

rebase

Harbormaster completed remote builds in B10798: Diff 14851.Jul 25 2022, 7:12 AM
Closed by commit rCOMMb79230129dab: [services] Backup - pull attachment holders out of the data section (authored by • karol). · Explain WhyJul 25 2022, 7:13 AM
This revision was automatically updated to reflect the committed changes.
• karol added a commit: rCOMMb79230129dab: [services] Backup - pull attachment holders out of the data section.

Revision Contents
Changeset List

PathSize
native/
cpp/
CommonCpp/
grpc/
protos/
10 lines

Diff 14860

View Options

native/cpp/CommonCpp/grpc/protos/backup.proto

Loading...