Page MenuHomePhabricator
Differential D4442

[services] Tests - Backup - Adjust the logic
AbandonedPublic
Actions

Authored by • karol on Jul 5 2022, 12:46 AM.
Tags
None
Referenced Files
Unknown Object (File)
Wed, Nov 13, 7:56 AM
Unknown Object (File)
Mon, Nov 11, 12:24 AM
Unknown Object (File)
Fri, Nov 8, 4:38 PM
Unknown Object (File)
Fri, Nov 8, 9:45 AM
Unknown Object (File)
Fri, Nov 8, 8:37 AM
Unknown Object (File)
Fri, Nov 8, 8:08 AM
Unknown Object (File)
Fri, Nov 8, 7:53 AM
Unknown Object (File)
Fri, Nov 8, 6:25 AM
View All Files
Subscribers
• abosh
• adrian
ashoat
atul
tomek

Details

Reviewers
tomek
varun
Summary

Depends on D4440

Adjusting the logic of the tests to changes from D4438. This means, we do not send attachment holders in a separate cycle but in the very first one for every log/backup (and for the consecutive ones, we don't send it - it is needed only once).

Test Plan
cd services
yarn run-integration-tests backup

Diff Detail

Repository
rCOMM Comm
Lint
No Lint Coverage
Unit
No Test Coverage

Event Timeline

• karol created this revision.Jul 5 2022, 12:46 AM
Herald added subscribers: • abosh, atul, • adrian and 2 others. · View Herald TranscriptJul 5 2022, 12:46 AM
Harbormaster returned this revision to the author for changes because remote builds failed.Jul 5 2022, 12:46 AM
Harbormaster failed remote builds in B10251: Diff 14143!
• karol requested review of this revision.Jul 5 2022, 1:23 AM
• karol edited the summary of this revision. (Show Details)
• karol edited the test plan for this revision. (Show Details)
• karol added reviewers: tomek, varun.
• karol added a parent revision: D4440: [services] Backup - Add extra bytes needed to the blob client.

CI is broken

• karol mentioned this in D4245: [services] Backup - Add current id and attachment holders.Jul 5 2022, 1:25 AM
• karol updated this revision to Diff 14171.Jul 5 2022, 3:40 AM
• karol edited the summary of this revision. (Show Details)

err msg

• karol planned changes to this revision.Jul 5 2022, 3:41 AM
• karol updated this revision to Diff 14173.Jul 5 2022, 3:42 AM

revert invalid change that was caused by the crash if vi

Harbormaster failed remote builds in B10279: Diff 14171!Jul 5 2022, 3:43 AM
Harbormaster failed remote builds in B10281: Diff 14173!
• karol updated this revision to Diff 14315.Jul 8 2022, 1:18 AM

rebase

Harbormaster failed remote builds in B10405: Diff 14315!Jul 8 2022, 1:19 AM
• karol updated this revision to Diff 14316.Jul 8 2022, 1:19 AM

rebase

Harbormaster failed remote builds in B10406: Diff 14316!Jul 8 2022, 1:20 AM
varun requested changes to this revision.Jul 13 2022, 1:50 PM

This run function is very long. Can we please move some of the logic to subroutines?

This revision now requires changes to proceed.Jul 13 2022, 1:50 PM
• karol abandoned this revision.Jul 18 2022, 7:02 AM

Revision Contents
Changeset List

PathSize
services/
commtest/
tests/
backup/
68 lines

Diff 14316

View Options

services/commtest/tests/backup/pull_backup.rs

Loading...