Paths

Table of Contentst

[nix] Remove python2
ClosedPublic
Actions

Authored by • jon on Jul 6 2022, 11:15 AM.

Tags

None

Referenced Files

	Unknown Object (File)
	Sat, Nov 2, 1:12 PM

	Unknown Object (File)
	Sat, Nov 2, 1:12 PM

	Unknown Object (File)
	Sat, Nov 2, 1:01 PM

	Unknown Object (File)
	Sat, Nov 2, 12:59 PM

	Unknown Object (File)
	Oct 7 2024, 4:46 AM

	Unknown Object (File)
	Sep 27 2024, 12:19 AM

	Unknown Object (File)
	Sep 2 2024, 4:02 PM

	Unknown Object (File)
	Sep 2 2024, 1:33 PM

Subscribers

Details

Reviewers

ashoat
varun
atul

Commits

rCOMM2354f271b361: [nix] Remove python2

Summary

No longer required by sqlite3

Test Plan

nix develop && yarn cleaninstall

Diff Detail

Repository

rCOMM Comm

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

• jon created this revision.Jul 6 2022, 11:15 AM

Herald added subscribers: • abosh, atul, • adrian, tomek. · View Herald TranscriptJul 6 2022, 11:15 AM

https://linear.app/comm/issue/ENG-1156/

Harbormaster completed remote builds in B10326: Diff 14233.Jul 6 2022, 11:27 AM

• jon requested review of this revision.Jul 6 2022, 11:27 AM

Tested on NixOS, m1 mac, and intel mac. All work

• jon edited the test plan for this revision. (Show Details)Jul 6 2022, 11:33 AM

Looks good, btw should we add nix develop && yarn cleaninstall to CI?

This revision is now accepted and ready to land.Jul 6 2022, 11:42 AM

Eventually we probably should, but I don't think it's necessary right now.

I think once https://linear.app/comm/issue/ENG-177/migrate-dev-environment-to-nix task is done, then that would be a better time.

Closed by commit rCOMM2354f271b361: [nix] Remove python2 (authored by • jon). · Explain WhyJul 6 2022, 12:04 PM

This revision was automatically updated to reflect the committed changes.

• jon added a commit: rCOMM2354f271b361: [nix] Remove python2.

Revision Contents
Changeset List

Path

Size

nix/

dev-shell.nix

2 lines

Diff 14234

View Options

[nix] Remove python2ClosedPublicActions