The diff extends ChatMessageListContainer with chat creation state.
When user enters chat chreation, the component uses useExistingThreadInfoFinder with pending personal private thread set as baseThread - so the behavior is the same as in native app.
Also, in thread creation mode, thread top bar, message list and input bar are displayed only if any users has been selected (so some thread from existingThreadInfoFider could be matched)
Details
Details
Currently there is no way in the app to enter the view by UI. The component can be displayed after entring url http://localhost/comm/chat/thread/new/.
Diff Detail
Diff Detail
- Repository
- rCOMM Comm
- Lint
Lint Not Applicable - Unit
Tests Not Applicable
Event Timeline
| web/chat/chat-message-list-container.react.js | ||
|---|---|---|
| 37–54 ↗ | (On Diff #14393) | A lot of work is done that isn't necessary when isChatCreation is false. Is there a way to avoid this? Maybe we can have a separate component that includes these hooks and is rendered conditionally based on the flag? |
| 87 ↗ | (On Diff #14393) | What is the scenario in which this effect is needed? |
| 95–96 ↗ | (On Diff #14393) | The 2nd condition is wider, so maybe we need only that one? |
| web/chat/chat-message-list-container.react.js | ||
|---|---|---|
| 87 ↗ | (On Diff #14393) | When user enter manually IDs into URL (like http://localhost/comm/chat/thread/new/84072,83850,99999) and some of them are not in userStore. |
| 95–96 ↗ | (On Diff #14393) | Probably yes, but isn't it faster to enter this branch by just confirming that sizes are different, than creating new set and invoke _isEqual? |
| web/chat/chat-message-list-container.react.js | ||
|---|---|---|
| 37–54 ↗ | (On Diff #14393) | Discussed offline - this approach was selected to avoid renders and possible state loss when switching from one mode to another - just like we do on native. |
| 95–96 ↗ | (On Diff #14393) | I don't think this optimization is really beneficial. Most of the times, we will still check the 2nd condition - after almost every dependency change. If we want to optimize here, we can create a memo with this Set and use it instead. |
| web/chat/chat-message-list-container.react.js | ||
|---|---|---|
| 95–96 ↗ | (On Diff #14393) | Didn't perform any tests with this, but I suppose this effect will usually be executed when adding or removing a user to the list, so in most cases the array length will change and we won't have to compare these arrays in the second condition. |
| web/chat/chat-message-list-container.react.js | ||
|---|---|---|
| 95–96 ↗ | (On Diff #14393) | When a performance difference isn't significant, I would prefer the readability. In this case, it would be slightly more readable if we had only one condition. But the readability difference is insignificant, so we can also keep it as it is. Up to you. |