Page MenuHomePhabricator
Differential D4487

[Chore] Ignore cmake build directories
ClosedPublic
Actions

Authored by • jon on Jul 8 2022, 9:55 PM.
Tags
None
Referenced Files
Unknown Object (File)
Fri, Mar 28, 7:06 AM
Unknown Object (File)
Tue, Mar 18, 10:57 AM
Unknown Object (File)
Sun, Mar 16, 11:37 AM
Unknown Object (File)
Wed, Mar 12, 3:24 PM
Unknown Object (File)
Mon, Mar 10, 1:27 PM
Unknown Object (File)
Mon, Mar 10, 1:25 PM
Unknown Object (File)
Sun, Mar 9, 10:54 AM
Unknown Object (File)
Fri, Mar 7, 4:59 AM
View All Files
Subscribers
• abosh
• adrian
ashoat
atul
tomek

Details

Reviewers
• max
• karol
ashoat
Commits
rCOMM45f41cbf6e94: [Chore] Ignore cmake build directories
Summary

Prevent build directories from
accidently being added

Test Plan

N/A

Diff Detail

Repository
rCOMM Comm
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

• jon created this revision.Jul 8 2022, 9:55 PM
Herald added subscribers: • abosh, atul, • adrian and 2 others. · View Herald TranscriptJul 8 2022, 9:55 PM
• jon added reviewers: • max, • karol.Jul 8 2022, 9:56 PM
Harbormaster completed remote builds in B10428: Diff 14372.Jul 8 2022, 10:05 PM
• jon requested review of this revision.Jul 8 2022, 10:05 PM
ashoat requested changes to this revision.Jul 9 2022, 10:47 AM

This is super general... can you share a list of the directories where this will come up? Wondering if we can prepend something in front of **/build maybe to at least limit this to the two or three subdirectories where we expect CMake builds to occur.

This revision now requires changes to proceed.Jul 9 2022, 10:47 AM
• jon updated this revision to Diff 14532.Jul 15 2022, 11:04 AM

Limit directory traversal to CMake directories

• jon added a comment.Jul 15 2022, 11:05 AM

I scoped the directories to be much smaller

Harbormaster completed remote builds in B10559: Diff 14532.Jul 15 2022, 11:15 AM
ashoat accepted this revision.Jul 17 2022, 7:30 AM
This revision is now accepted and ready to land.Jul 17 2022, 7:30 AM
Closed by commit rCOMM45f41cbf6e94: [Chore] Ignore cmake build directories (authored by • jon). · Explain WhyJul 17 2022, 11:51 PM
This revision was automatically updated to reflect the committed changes.
• jon added a commit: rCOMM45f41cbf6e94: [Chore] Ignore cmake build directories.
• jon mentioned this in D4489: [Services] Export shared services cpp as CMake Project.Aug 4 2022, 12:55 PM

Revision Contents
Changeset List

PathSize
5 lines

Diff 14558

View Options

.gitignore

Show All 10 Lines
div.messageActionContainer { div.messageActionContainer {
display: flex; display: flex;
flex-direction: row; flex-direction: row;
align-items: center; align-items: center;
justify-content: center; justify-content: center;
background-color: var(--message-action-tooltip-bg); background-color: var(--message-action-tooltip-bg);
border-radius: 8px; border-radius: 8px;
width: fit-content; width: fit-content;
box-shadow: var(--message-action-tooltip-bg) 0 2px 8px;
} }
div.messageActionButtons { div.messageActionButtons {
display: flex; display: flex;
font-size: 16px; font-size: 16px;
} }
div.messageActionButtons svg { div.messageActionButtons svg {
padding: 10px 6px 6px; padding: 10px 6px 6px;
Show All 17 Linesdiv.messageTooltipLabel {
flex-direction: row; flex-direction: row;
align-items: center; align-items: center;
justify-content: center; justify-content: center;
background-color: var(--message-action-tooltip-bg); background-color: var(--message-action-tooltip-bg);
color: var(--tool-tip-color); color: var(--tool-tip-color);
border-radius: 8px; border-radius: 8px;
overflow: auto; overflow: auto;
white-space: nowrap; white-space: nowrap;
box-shadow: var(--message-action-tooltip-bg) 0 2px 8px;
} }
div.leftTooltipAlign { div.leftTooltipAlign {
align-items: flex-start; align-items: flex-start;
} }
div.centerTooltipAlign { div.centerTooltipAlign {
align-items: center; align-items: center;
Show All 10 Lines