[Chore] Ignore cmake build directories
ClosedPublic
Actions

Authored by • jon on Jul 8 2022, 9:55 PM.

Details

Reviewers

• max
• karol
ashoat

Commits

rCOMM45f41cbf6e94: [Chore] Ignore cmake build directories

Summary

Prevent build directories from
accidently being added

Test Plan

N/A

Diff Detail

Repository

rCOMM Comm

Branch

jonringer-ignore-cmake

Lint

No Lint Coverage

Unit

No Test Coverage

Event Timeline

• jon created this revision.Jul 8 2022, 9:55 PM

Herald added subscribers: • abosh, atul, • adrian and 2 others. · View Herald TranscriptJul 8 2022, 9:55 PM

• jon added reviewers: • max, • karol.Jul 8 2022, 9:56 PM

Harbormaster completed remote builds in B10428: Diff 14372.Jul 8 2022, 10:05 PM

• jon requested review of this revision.Jul 8 2022, 10:05 PM

This is super general... can you share a list of the directories where this will come up? Wondering if we can prepend something in front of **/build maybe to at least limit this to the two or three subdirectories where we expect CMake builds to occur.

This revision now requires changes to proceed.Jul 9 2022, 10:47 AM

Limit directory traversal to CMake directories

I scoped the directories to be much smaller

Harbormaster completed remote builds in B10559: Diff 14532.Jul 15 2022, 11:15 AM

ashoat accepted this revision.Jul 17 2022, 7:30 AM

This revision is now accepted and ready to land.Jul 17 2022, 7:30 AM

Closed by commit rCOMM45f41cbf6e94: [Chore] Ignore cmake build directories (authored by • jon). · Explain WhyJul 17 2022, 11:51 PM

This revision was automatically updated to reflect the committed changes.

• jon added a commit: rCOMM45f41cbf6e94: [Chore] Ignore cmake build directories.

• jon mentioned this in D4489: [Services] Export shared services cpp as CMake Project.Aug 4 2022, 12:55 PM