Page MenuHomePhabricator
Differential D4504

[services] Backup - Remove unnecessary brackets in unit test
ClosedPublic
Actions

Authored by • jakub on Jul 12 2022, 1:19 AM.
Tags
None
Referenced Files
Unknown Object (File)
Tue, May 14, 6:41 AM
Unknown Object (File)
Fri, Apr 19, 4:30 PM
Unknown Object (File)
Fri, Apr 19, 4:30 PM
Unknown Object (File)
Fri, Apr 19, 4:29 PM
Unknown Object (File)
Fri, Apr 19, 4:25 PM
Unknown Object (File)
Apr 13 2024, 1:40 PM
Unknown Object (File)
Apr 13 2024, 1:40 PM
Unknown Object (File)
Apr 13 2024, 1:40 PM
View All 89 Files
Subscribers
• abosh
• adrian
ashoat
atul
• karol
tomek

Details

Reviewers
tomek
• karol
Commits
rCOMM80b0b0f5fb84: [services] Backup - Remove unnecessary brackets in unit test
Summary

Depends on D4503
Removing redundant brackets in generating functions

Test Plan

cd services && yarn run-unit-tests backup

Diff Detail

Repository
rCOMM Comm
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

• jakub created this revision.Jul 12 2022, 1:19 AM
Herald added subscribers: • abosh, • karol, atul and 3 others. · View Herald TranscriptJul 12 2022, 1:19 AM
• jakub added a child revision: D4505: [services] Backup - Add function to get utf8 string length.Jul 12 2022, 1:23 AM
• jakub edited the summary of this revision. (Show Details)
• jakub added a parent revision: D4503: [services] Backup - Fix missing hash in unit tests.
Harbormaster completed remote builds in B10461: Diff 14406.Jul 12 2022, 1:31 AM
• jakub requested review of this revision.Jul 12 2022, 1:31 AM
• jakub edited the summary of this revision. (Show Details)Jul 12 2022, 1:57 AM
• jakub edited the test plan for this revision. (Show Details)
• jakub edited the test plan for this revision. (Show Details)Jul 12 2022, 2:14 AM
ashoat added a comment.Jul 12 2022, 12:01 PM

Make sure to always add a reviewer when you put your diffs up! Otherwise nobody will look

• jakub added reviewers: tomek, • karol.Jul 13 2022, 5:11 AM
• karol accepted this revision.Jul 18 2022, 1:27 AM
• karol added 1 blocking reviewer(s): tomek.
tomek accepted this revision.Jul 18 2022, 5:35 AM
This revision is now accepted and ready to land.Jul 18 2022, 5:35 AM
Closed by commit rCOMM80b0b0f5fb84: [services] Backup - Remove unnecessary brackets in unit test (authored by • jakub). · Explain WhyJul 27 2022, 7:35 AM
This revision was automatically updated to reflect the committed changes.
• jakub added a commit: rCOMM80b0b0f5fb84: [services] Backup - Remove unnecessary brackets in unit test.

Revision Contents
Changeset List

PathSize
services/
backup/
test/
4 lines

Diff 15018

View Options

services/backup/test/DatabaseManagerTest.cpp

Loading...