Page MenuHomePhabricator

jakub (Jakub Kędra)
User

Projects

User does not belong to any projects.

User Details

User Since
Jul 5 2022, 6:36 AM (12 w, 5 d)

Recent Activity

Fri, Sep 30

jakub closed D5211: [web] Connect `ComposeSubchannel` modal with keyserver.
Fri, Sep 30, 2:15 PM
jakub committed rCOMM3bd69b66b007: [web] Connect `ComposeSubchannel` modal with keyserver (authored by jakub).
[web] Connect `ComposeSubchannel` modal with keyserver
Fri, Sep 30, 2:15 PM
jakub closed D5187: [web] Introduce `ComposeSubchannel` modal.
Fri, Sep 30, 2:15 PM
jakub committed rCOMM46eea5ddf046: [web] Introduce `ComposeSubchannel` modal (authored by jakub).
[web] Introduce `ComposeSubchannel` modal
Fri, Sep 30, 2:15 PM
jakub added inline comments to D5211: [web] Connect `ComposeSubchannel` modal with keyserver.
Fri, Sep 30, 7:25 AM
jakub updated the diff for D5211: [web] Connect `ComposeSubchannel` modal with keyserver.

Adjust to code review

Fri, Sep 30, 7:25 AM
jakub updated the summary of D5187: [web] Introduce `ComposeSubchannel` modal.
Fri, Sep 30, 7:02 AM
jakub updated the diff for D5187: [web] Introduce `ComposeSubchannel` modal.

Remove key prop from Stepper.Item

Fri, Sep 30, 6:59 AM
jakub added inline comments to D5211: [web] Connect `ComposeSubchannel` modal with keyserver.
Fri, Sep 30, 6:41 AM
jakub updated the diff for D5211: [web] Connect `ComposeSubchannel` modal with keyserver.

Adjust to code review:

  • change closed to secret
  • replace threadTypesPerVisibility with getThreadType function
Fri, Sep 30, 6:41 AM
jakub updated the diff for D5187: [web] Introduce `ComposeSubchannel` modal.

Change closed to secret

Fri, Sep 30, 6:39 AM
jakub planned changes to D5187: [web] Introduce `ComposeSubchannel` modal.
Fri, Sep 30, 6:39 AM
jakub closed D5222: [web] Clear error message during switching between tabs in `ThreadSettingsModal`.
Fri, Sep 30, 6:01 AM
jakub committed rCOMMbbd050c98ab3: [web] Clear error message during switching between tabs in `ThreadSettingsModal` (authored by jakub).
[web] Clear error message during switching between tabs in `ThreadSettingsModal`
Fri, Sep 30, 6:01 AM
jakub closed D5220: [web] Keep submit buttons always on the bottom of the `ThreadSettingsModal`.
Fri, Sep 30, 6:01 AM
jakub committed rCOMMee142f1d4978: [web] Keep submit buttons always on the bottom of the `ThreadSettingsModal` (authored by jakub).
[web] Keep submit buttons always on the bottom of the `ThreadSettingsModal`
Fri, Sep 30, 6:00 AM
jakub updated the diff for D5222: [web] Clear error message during switching between tabs in `ThreadSettingsModal`.

Rebase before landing

Fri, Sep 30, 5:49 AM
jakub updated the diff for D5220: [web] Keep submit buttons always on the bottom of the `ThreadSettingsModal`.

Rebase before landing

Fri, Sep 30, 5:46 AM
jakub updated the summary of D5186: [web] Introduce `Stepper` - common multiple step component.
Fri, Sep 30, 2:50 AM

Thu, Sep 29

jakub added a comment to D5211: [web] Connect `ComposeSubchannel` modal with keyserver.

Thanks! Now it should work

Thu, Sep 29, 12:45 PM
jakub attached a referenced file: F185898: image.png.
Thu, Sep 29, 12:42 PM
jakub attached a referenced file: F186163: position-sticky.mov.
Thu, Sep 29, 11:42 AM
jakub updated the diff for D5220: [web] Keep submit buttons always on the bottom of the `ThreadSettingsModal`.

Adjust to code review:

  • set error message as optional nullable value
Thu, Sep 29, 11:30 AM
jakub attached a referenced file: F185270: image.png.
Thu, Sep 29, 11:09 AM
jakub added inline comments to D5187: [web] Introduce `ComposeSubchannel` modal.
Thu, Sep 29, 10:53 AM
jakub updated the diff for D5187: [web] Introduce `ComposeSubchannel` modal.

Adjust to code review:

  • move Stepper.Items directly to Stepper.Container
  • replacing empty string with stringForUser function
Thu, Sep 29, 10:51 AM
jakub added inline comments to D5211: [web] Connect `ComposeSubchannel` modal with keyserver.
Thu, Sep 29, 9:50 AM
jakub updated the diff for D5211: [web] Connect `ComposeSubchannel` modal with keyserver.

Adjust to code review:

  • fix typo
  • change matrix name to threadTypesPerVisibility
  • use createLoadingStatusIndicator instead of using component state
Thu, Sep 29, 9:48 AM
jakub closed D5186: [web] Introduce `Stepper` - common multiple step component.
Thu, Sep 29, 6:38 AM
jakub committed rCOMMc9c012b417b6: [web] Introduce `Stepper` - common multiple step component (authored by jakub).
[web] Introduce `Stepper` - common multiple step component
Thu, Sep 29, 6:38 AM
jakub updated the diff for D5186: [web] Introduce `Stepper` - common multiple step component.

Rebase before landing

Thu, Sep 29, 6:26 AM
jakub added inline comments to D5187: [web] Introduce `ComposeSubchannel` modal.
Thu, Sep 29, 6:14 AM
jakub updated the diff for D5187: [web] Introduce `ComposeSubchannel` modal.

Adjust to code review:

  • fix stepContainer height
  • change <not specified to community
  • filter empty-username users from list
  • add new css variables
Thu, Sep 29, 6:14 AM
jakub updated the diff for D5186: [web] Introduce `Stepper` - common multiple step component.

Adjust to code review:

  • add margin to gap between buttons and the step content
  • remove additional spaces
  • simplify code
  • use classnames instead of string literals
Thu, Sep 29, 4:35 AM
jakub added inline comments to D5220: [web] Keep submit buttons always on the bottom of the `ThreadSettingsModal`.
Thu, Sep 29, 2:31 AM
jakub updated the diff for D5220: [web] Keep submit buttons always on the bottom of the `ThreadSettingsModal`.

Adjust to code review:

  • set button type as submit
  • flex adjustments
  • change height: 100% to flex: 1
  • use classnames for containerStyle
  • round fractional height
Thu, Sep 29, 2:31 AM

Wed, Sep 28

jakub updated the diff for D5187: [web] Introduce `ComposeSubchannel` modal.

Rebase

Wed, Sep 28, 6:28 AM
jakub planned changes to D5187: [web] Introduce `ComposeSubchannel` modal.
Wed, Sep 28, 4:56 AM
jakub attached a referenced file: F184469: error-message-settings.mov.
Wed, Sep 28, 4:33 AM
jakub added inline comments to D5220: [web] Keep submit buttons always on the bottom of the `ThreadSettingsModal`.
Wed, Sep 28, 4:06 AM
jakub added a comment to D5222: [web] Clear error message during switching between tabs in `ThreadSettingsModal`.
In D5222#154090, @tomek wrote:
In D5222#153960, @atul wrote:

Based on the video you provided, should we also gray out the Delete button in the Delete tab if the password input field is empty?

Yeah, sounds like a good idea. We should create a new task for it and implement it when appropriate. @jakub could you create a task?

Wed, Sep 28, 4:06 AM
jakub updated the diff for D5222: [web] Clear error message during switching between tabs in `ThreadSettingsModal`.

Adjust to code review and rebase

Wed, Sep 28, 4:03 AM
jakub updated the diff for D5220: [web] Keep submit buttons always on the bottom of the `ThreadSettingsModal`.

Adjust to code review:

  • change SubmitButton name to SubmitSection
  • remove min-height property
  • simplify code and remove unnecessary spaces
Wed, Sep 28, 3:46 AM
jakub updated the diff for D5186: [web] Introduce `Stepper` - common multiple step component.

Adjust to code review:

  • Change ActionButtonsProps to readonly props
  • use new name prop instead of using key
  • remove errorMessage fixed size
Wed, Sep 28, 2:36 AM
jakub added inline comments to D5186: [web] Introduce `Stepper` - common multiple step component.
Wed, Sep 28, 2:35 AM

Tue, Sep 27

jakub added inline comments to D5187: [web] Introduce `ComposeSubchannel` modal.
Tue, Sep 27, 11:23 AM
jakub updated the diff for D5187: [web] Introduce `ComposeSubchannel` modal.

Adjust to code review:

  • change flag icon to megaphone,
  • remove unnecessary whitespaces,
  • simplify code,
  • memoize steps,
  • use css variables from typography.css and theme.css,
  • adjust userInfos in MembersList to new type of AddMembersList
Tue, Sep 27, 11:20 AM
jakub attached a referenced file: F183014: with height.mov.
Tue, Sep 27, 4:09 AM
jakub attached a referenced file: F183013: without height.mov.
Tue, Sep 27, 4:09 AM
jakub closed D5185: [web] Make `AddMembersList` more universal.
Tue, Sep 27, 2:38 AM
jakub committed rCOMMd1d82f4ef167: [web] Make `AddMembersList` more universal (authored by jakub).
[web] Make `AddMembersList` more universal
Tue, Sep 27, 2:38 AM
jakub updated the diff for D5185: [web] Make `AddMembersList` more universal.

Rebase before landing

Tue, Sep 27, 2:25 AM
jakub added inline comments to D5186: [web] Introduce `Stepper` - common multiple step component.
Tue, Sep 27, 2:21 AM
jakub updated the diff for D5186: [web] Introduce `Stepper` - common multiple step component.

Adjust to code review: simplify code, move prepareButton function outside StepperItem
component, remove unnecessary css prop

Tue, Sep 27, 2:18 AM

Mon, Sep 26

jakub updated the diff for D5185: [web] Make `AddMembersList` more universal.

Memoize sortedGroupedUsersList

Mon, Sep 26, 11:38 AM
jakub updated the diff for D5185: [web] Make `AddMembersList` more universal.

Change MemberGroupItem types and memoize sortedGroupedUsersList

Mon, Sep 26, 7:01 AM
jakub closed D5115: [web] Added possibility to change input type and icon position in EnumSettingsOption.
Mon, Sep 26, 3:55 AM
jakub committed rCOMM8e2208623fcd: [web] Added possibility to change input type and icon position in… (authored by jakub).
[web] Added possibility to change input type and icon position in…
Mon, Sep 26, 3:55 AM
jakub updated the diff for D5115: [web] Added possibility to change input type and icon position in EnumSettingsOption.

Rebase before landing

Mon, Sep 26, 3:37 AM
jakub updated the summary of D5115: [web] Added possibility to change input type and icon position in EnumSettingsOption.
Mon, Sep 26, 3:30 AM

Fri, Sep 23

jakub updated the summary of D5222: [web] Clear error message during switching between tabs in `ThreadSettingsModal`.
Fri, Sep 23, 7:46 AM
jakub requested review of D5222: [web] Clear error message during switching between tabs in `ThreadSettingsModal`.
Fri, Sep 23, 7:39 AM
jakub requested review of D5220: [web] Keep submit buttons always on the bottom of the `ThreadSettingsModal`.
Fri, Sep 23, 7:37 AM
jakub updated the diff for D5186: [web] Introduce `Stepper` - common multiple step component.

Rebase

Fri, Sep 23, 1:38 AM

Thu, Sep 22

jakub updated the summary of D5211: [web] Connect `ComposeSubchannel` modal with keyserver.
Thu, Sep 22, 7:30 AM
jakub requested review of D5211: [web] Connect `ComposeSubchannel` modal with keyserver.
Thu, Sep 22, 6:53 AM
jakub updated the diff for D5186: [web] Introduce `Stepper` - common multiple step component.

Move error message to left side

Thu, Sep 22, 6:53 AM
jakub planned changes to D5186: [web] Introduce `Stepper` - common multiple step component.
Thu, Sep 22, 6:51 AM
jakub planned changes to D5211: [web] Connect `ComposeSubchannel` modal with keyserver.
Thu, Sep 22, 6:47 AM
jakub requested review of D5211: [web] Connect `ComposeSubchannel` modal with keyserver.
Thu, Sep 22, 5:31 AM
jakub updated the diff for D5186: [web] Introduce `Stepper` - common multiple step component.

Add div for error messages

Thu, Sep 22, 4:30 AM
jakub planned changes to D5186: [web] Introduce `Stepper` - common multiple step component.
Thu, Sep 22, 4:19 AM

Wed, Sep 21

jakub updated the diff for D5186: [web] Introduce `Stepper` - common multiple step component.

Add optional LoadingIndicator to buttons

Wed, Sep 21, 6:25 AM

Tue, Sep 20

jakub requested review of D5187: [web] Introduce `ComposeSubchannel` modal.
Tue, Sep 20, 12:12 PM
jakub updated the diff for D5186: [web] Introduce `Stepper` - common multiple step component.

Rebase

Tue, Sep 20, 11:36 AM
jakub updated the diff for D5185: [web] Make `AddMembersList` more universal.

Rebase

Tue, Sep 20, 11:32 AM
jakub updated the diff for D5115: [web] Added possibility to change input type and icon position in EnumSettingsOption.

Rebase and move additional types declarations before Props type

Tue, Sep 20, 11:28 AM
jakub abandoned D5113: [web] Introducing `ModalLabel` component.

After discussion in real life, I decided to abandon this diff and include this component directly to ComposeSubchannel

Tue, Sep 20, 11:11 AM
jakub updated the summary of D5186: [web] Introduce `Stepper` - common multiple step component.
Tue, Sep 20, 2:48 AM
jakub updated the summary of D5186: [web] Introduce `Stepper` - common multiple step component.
Tue, Sep 20, 2:30 AM
jakub updated the summary of D5185: [web] Make `AddMembersList` more universal.
Tue, Sep 20, 2:14 AM
jakub updated the summary of D5185: [web] Make `AddMembersList` more universal.
Tue, Sep 20, 2:13 AM
jakub updated the summary of D5185: [web] Make `AddMembersList` more universal.
Tue, Sep 20, 2:12 AM
jakub requested review of D5186: [web] Introduce `Stepper` - common multiple step component.
Tue, Sep 20, 1:33 AM
jakub requested review of D5185: [web] Make `AddMembersList` more universal.
Tue, Sep 20, 1:29 AM

Mon, Sep 19

jakub updated the diff for D5115: [web] Added possibility to change input type and icon position in EnumSettingsOption.

Set readOnly as optional param and use $Keys instead of hardcoding IconPosition type

Mon, Sep 19, 2:06 AM
jakub closed D4940: [web] Change ThreadList behaviour after hiding ChatThreadComposer.
Mon, Sep 19, 1:25 AM
jakub committed rCOMM3fd1233147c1: [web] Change ThreadList behaviour after hiding ChatThreadComposer (authored by jakub).
[web] Change ThreadList behaviour after hiding ChatThreadComposer
Mon, Sep 19, 1:25 AM
jakub updated the diff for D4940: [web] Change ThreadList behaviour after hiding ChatThreadComposer.

Rebase before landing

Mon, Sep 19, 1:14 AM

Fri, Sep 16

jakub updated the diff for D5115: [web] Added possibility to change input type and icon position in EnumSettingsOption.

Changing % to px units, set default value of type param, move iconPositionClassNames outside of the component and adjust to codebase

Fri, Sep 16, 1:54 AM
jakub updated the diff for D5113: [web] Introducing `ModalLabel` component.

Adjust to codebase

Fri, Sep 16, 1:24 AM
jakub closed D5110: [web] Fix warning - set readOnly param to EnumSettingOption radio.
Fri, Sep 16, 1:09 AM
jakub committed rCOMM692c8b02a310: [web] Fix warning - set readOnly param to EnumSettingOption radio (authored by jakub).
[web] Fix warning - set readOnly param to EnumSettingOption radio
Fri, Sep 16, 1:09 AM
jakub added a comment to D5110: [web] Fix warning - set readOnly param to EnumSettingOption radio.

By default, this Radio component is only used in and controlled by EnumSettingsOption component. So basically, we don't need to pass any onChange function to them.

Fri, Sep 16, 12:59 AM
jakub updated the diff for D4940: [web] Change ThreadList behaviour after hiding ChatThreadComposer.

Rebase branch and rename ActiveThreadBehaviour and conditionalOnClick

Fri, Sep 16, 12:43 AM
jakub updated the summary of D4940: [web] Change ThreadList behaviour after hiding ChatThreadComposer.
Fri, Sep 16, 12:11 AM

Mon, Sep 12

jakub updated the summary of D5115: [web] Added possibility to change input type and icon position in EnumSettingsOption.
Mon, Sep 12, 9:25 AM
jakub requested review of D5115: [web] Added possibility to change input type and icon position in EnumSettingsOption.
Mon, Sep 12, 9:02 AM
jakub retitled D5113: [web] Introducing `ModalLabel` component from [web] Introducing ModalLabel to [web] Introducing `ModalLabel` component.
Mon, Sep 12, 8:22 AM
jakub requested review of D5113: [web] Introducing `ModalLabel` component.
Mon, Sep 12, 7:22 AM