Fixing warning that occur on controlled radio input in EnumSettingsOption
Warning communiqué:
Details
Details
- Open console
- Open any modal that uses EnumSettingOption (e.g. channel notification modal)
- Now, this warning doesn't appear
Diff Detail
Diff Detail
- Repository
- rCOMM Comm
- Lint
Lint Not Applicable - Unit
Tests Not Applicable
Event Timeline
Comment Actions
Accepting with question
Do we not want this Radio component to be interactive, or is this readOnly included temporary until onChange is implemented?
Comment Actions
By default, this Radio component is only used in and controlled by EnumSettingsOption component. So basically, we don't need to pass any onChange function to them.
| web/components/radio.react.js | ||
|---|---|---|
| 10–13 | Can we introduce a new prop readOnly to this component so that it remains usable in different contexts? | |