Fixing warning that occur on controlled radio input in EnumSettingsOption
Warning communiqué:
Differential D5110 Authored by • jakub on Sep 12 2022, 5:55 AM.
Details Summary Test Plan
Diff Detail
Event TimelineHerald added subscribers: • abosh, atul, tomek, ashoat. · View Herald TranscriptSep 12 2022, 5:55 AM2022-09-12 05:55:28 (UTC-7) • jakub edited the summary of this revision. (Show Details)Sep 12 2022, 6:03 AM2022-09-12 06:03:04 (UTC-7) Harbormaster completed remote builds in B12080: Diff 16580.Sep 12 2022, 6:05 AM2022-09-12 06:05:01 (UTC-7) • jakub added a child revision: D5113: [web] Introducing `ModalLabel` component.Sep 12 2022, 8:22 AM2022-09-12 08:22:35 (UTC-7) Comment Actions Accepting with question Do we not want this Radio component to be interactive, or is this readOnly included temporary until onChange is implemented? This revision now requires changes to proceed.Sep 15 2022, 7:45 AM2022-09-15 07:45:32 (UTC-7) This revision is now accepted and ready to land.Sep 15 2022, 7:45 AM2022-09-15 07:45:41 (UTC-7) Comment Actions By default, this Radio component is only used in and controlled by EnumSettingsOption component. So basically, we don't need to pass any onChange function to them. Closed by commit rCOMM692c8b02a310: [web] Fix warning - set readOnly param to EnumSettingOption radio (authored by • jakub). · Explain WhySep 16 2022, 1:09 AM2022-09-16 01:09:14 (UTC-7) This revision was automatically updated to reflect the committed changes.
Revision Contents
Diff 16732 web/components/radio.react.js
|