[server] Add delay before setuping database and running migrations
ClosedPublic
Actions

Authored by • jacek on Jul 12 2022, 5:26 AM.

Details

Reviewers

tomek
atul
ashoat

Commits

rCOMM4e21e3d264df: [server] Add delay before setuping database and running migrations

Summary

Linear: https://linear.app/comm/issue/ENG-1350/investigate-why-new-messages-are-not-displayed-when-keyserver
Introduce 5s delay before running database setup script and migrations in dev mode.
This prevents executing migrations and db setup script while project files are compiled after running yarn dev and nodemon restarts a few times.

Test Plan

I dropped database, and run yarn dev with and without fix, confirming that DB setup was fully completed using logs. Also checked threads table in DB to confirm the initial threads are created.

Diff Detail

Repository

rCOMM Comm

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

• jacek created this revision.Jul 12 2022, 5:26 AM

Herald added subscribers: • abosh, • adrian, ashoat. · View Herald TranscriptJul 12 2022, 5:26 AM

• jacek edited the summary of this revision. (Show Details)Jul 12 2022, 5:27 AM

Harbormaster completed remote builds in B10464: Diff 14409.Jul 12 2022, 5:38 AM

• jacek requested review of this revision.Jul 12 2022, 5:38 AM

ashoat accepted this revision.Jul 12 2022, 12:08 PM

ashoat added inline comments.

keyserver/src/database/migrations.js
15 ↗	(On Diff #14409)	This variable declaration should be grouped with the `try-catch` that sets it below

This revision is now accepted and ready to land.Jul 12 2022, 12:08 PM

• jacek added a child revision: D4514: [server] Use single connection with DB for migrations.Jul 13 2022, 8:08 AM

• jacek added inline comments.Jul 13 2022, 8:13 AM

keyserver/src/database/migrations.js
15 ↗	(On Diff #14409)	I think it can't be inside `try-catch`, because it's used in line 30 - out of the block. Or do you mean just moving it to line 19?