[native] Merge conditionals in `InputStateContainer`
ClosedPublic
Actions

Authored by • abosh on Jul 12 2022, 11:17 AM.

Details

Reviewers

atul
tomek
• jacek

Commits

rCOMM82db148f42fa: [native] Merge conditionals in `InputStateContainer`

Summary

Minor change which merges conditional logic in InputStateContainer since the code in each block is the exact same.

Test Plan

Flow, close reading.

Diff Detail

Repository

rCOMM Comm

Branch

master

Lint

No Lint Coverage

Unit

No Test Coverage

Event Timeline

• abosh created this revision.Jul 12 2022, 11:17 AM

Herald added subscribers: • adrian, ashoat. · View Herald TranscriptJul 12 2022, 11:17 AM

Harbormaster completed remote builds in B10467: Diff 14413.Jul 12 2022, 11:30 AM

• abosh requested review of this revision.Jul 12 2022, 11:30 AM

Is Flow cool with this now? Nice

It would appear so! :D

In D4509#128346, @ashoat wrote:

Is Flow cool with this now? Nice

Yeah, we actually changed this to see what the error flow would give was, but it worked fine

atul accepted this revision.Jul 13 2022, 1:20 PM

This revision is now accepted and ready to land.Jul 13 2022, 1:20 PM

Closed by commit rCOMM82db148f42fa: [native] Merge conditionals in `InputStateContainer` (authored by • abosh). · Explain WhyJul 13 2022, 1:37 PM

This revision was automatically updated to reflect the committed changes.

• abosh added a commit: rCOMM82db148f42fa: [native] Merge conditionals in `InputStateContainer`.

Revision Contents
Changeset List

Path

Size

native/

input/

input-state-container.react.js

24 lines

Diff 14413

View Options

native/input/input-state-container.react.js

[native] Merge conditionals in `InputStateContainer`ClosedPublicActions