[services] add pre commit hook for terraform files
ClosedPublic
Actions

Authored by varun on Jul 13 2022, 1:14 PM.

Details

Reviewers

• abosh
• karol
ashoat

Commits

rCOMM64c6c9934178: [services] add pre commit hook for terraform files

Summary

Terraform has opinionated style conventions that we should follow, just so that our .tf files look consistent. This commit introduces a pre-commit hook to check the formatting and validity of our .tf files.

Test Plan

Tried to commit invalid terraform code and the hook was triggered

Diff Detail

Repository

rCOMM Comm

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

varun created this revision.Jul 13 2022, 1:14 PM

Herald added subscribers: atul, • adrian, tomek, ashoat. · View Herald TranscriptJul 13 2022, 1:14 PM

Harbormaster completed remote builds in B10499: Diff 14446.Jul 13 2022, 1:27 PM

varun requested review of this revision.Jul 13 2022, 1:27 PM

Looks good!

scripts/terraform_pre_commit.sh
10 ↗	(On Diff #14446)	Just making sure there's a newline at the end of this file, correct? I think Phabricator truncates it by default (just by looking at other JS diffs that have ESLint/Flow checks that ensure a newline is at the end of the file, because Phabricator doesn't show the newline in those either).

This revision is now accepted and ready to land.Jul 13 2022, 1:54 PM

Herald added a reviewer: ashoat. · View Herald TranscriptJul 13 2022, 1:54 PM

This revision now requires review to proceed.Jul 13 2022, 1:54 PM

varun added inline comments.Jul 13 2022, 1:56 PM

scripts/terraform_pre_commit.sh
10 ↗	(On Diff #14446)	Yeah there is, I think phabricator adds a "no new line" warning on the diff if you forget

Nice. Can you create tasks for adding these to GitHub Actions and Buildkite? Feel free to leave them as Backlog/unassigned

This revision is now accepted and ready to land.Jul 13 2022, 4:36 PM

Closed by commit rCOMM64c6c9934178: [services] add pre commit hook for terraform files (authored by varun). · Explain WhyJul 14 2022, 7:40 AM

This revision was automatically updated to reflect the committed changes.

varun added a commit: rCOMM64c6c9934178: [services] add pre commit hook for terraform files.

In D4527#128740, @ashoat wrote:

Nice. Can you create tasks for adding these to GitHub Actions and Buildkite? Feel free to leave them as Backlog/unassigned

done