Paths

Table of Contentst

-
lib/reducers/
-
reducers/
2/4
message-reducer.test.js

[lib] Introduce basic tests for `SET_MESSAGE_STORE_MESSAGES` action
ClosedPublic
Actions

Authored by atul on Jul 18 2022, 1:44 PM.

Details

Reviewers

• jacek
marcin
tomek

Commits

rCOMMa7ccdefd49ef: [lib] Introduce basic tests for `SET_MESSAGE_STORE_MESSAGES` action

Summary

Had trouble debugging D4508 because I couldn't "attach" debugger to hermes in time for message-reducer.js:SET_MESSAGE_STORE_MESSAGES to hit.

Ended up testing via console.log(...) and pasting values into a text file to ensure that things were as expected. The stuff I jotted down lent itself well to writing basic unit tests so figured I might as well put it up.

Depends on D4508

Test Plan

Ran tests

Diff Detail

Repository

rCOMM Comm

Branch

arcpatch-D4560

Lint

No Lint Coverage

Unit

No Test Coverage

Event Timeline

atul created this revision.Jul 18 2022, 1:44 PM

Herald added subscribers: • abosh, • adrian, ashoat. · View Herald TranscriptJul 18 2022, 1:44 PM

Harbormaster completed remote builds in B10592: Diff 14584.Jul 18 2022, 1:56 PM

atul requested review of this revision.Jul 18 2022, 1:56 PM

tomek accepted this revision.Jul 19 2022, 2:44 AM

This revision is now accepted and ready to land.Jul 19 2022, 2:44 AM

atul edited the summary of this revision. (Show Details)Jul 20 2022, 7:26 AM

atul added a parent revision: D4508: Filter local multimedia messages.

rebase before landign

rebase before landing

Harbormaster completed remote builds in B10742: Diff 14782.Jul 21 2022, 12:25 PM

Harbormaster completed remote builds in B10743: Diff 14783.

Closed by commit rCOMMa7ccdefd49ef: [lib] Introduce basic tests for `SET_MESSAGE_STORE_MESSAGES` action (authored by atul). · Explain WhyJul 21 2022, 2:15 PM

This revision was automatically updated to reflect the committed changes.

atul added a commit: rCOMMa7ccdefd49ef: [lib] Introduce basic tests for `SET_MESSAGE_STORE_MESSAGES` action.

Revision Contents
Changeset List

Path

Size

lib/

reducers/

message-reducer.test.js

107 lines

Diff 14782

View Options

lib/reducers/message-reducer.test.js

This file was added.

				div.containerViewerLiked {
				padding: 4px;
				border-radius: 4px;
				background-color: var(--shades-black-80);
				}

				div.container:hover {
				cursor: pointer;
				}
				tomekUnsubmitted Not Done Inline Actions For other tooltip actions we don't need to manually set this style. Can we use the mechanism we already have, or are there any reasons for not doing so? tomek: For other tooltip actions we don't need to manually set this style. Can we use the mechanism we…
				ginsuAuthorUnsubmitted Done Inline Actions I believe the other icons don't need to set this style because it is built into `IcomoonReact`. When I switched the Like action tooltip button with one of the icons the hover style just works out of the box. Wondering if @atul has more context since he is pretty familiar with the icons stuff ginsu: I believe the other icons don't need to set this style because it is built into `IcomoonReact`.
				tomekUnsubmitted Not Done Inline Actions It wouldn't make too much sense for `Icomoon` to provide hover effects for icons because they could be used in other places - not only as buttons. It seems like the style on hover is applied in `message-tooltip.css` div.messageActionButtons svg:hover { cursor: pointer; color: var(--fg); } so it should be enough to apply this style also to the new button. tomek: It wouldn't make too much sense for `Icomoon` to provide hover effects for icons because they…
				ginsuAuthorUnsubmitted Done Inline Actions Ahhhhh that makes sense, thank you for clarifying, I will make the necessary changes ginsu: Ahhhhh that makes sense, thank you for clarifying, I will make the necessary changes

[lib] Introduce basic tests for `SET_MESSAGE_STORE_MESSAGES` actionClosedPublicActions