Differential D4572

change thread operations utilities paths in XCode so that they can be debugged
ClosedPublic
Actions

Authored by marcin on Jul 19 2022, 2:40 AM.

Tags

None

Referenced Files

	F3893774: D4572.diff
	Sat, Jan 25, 3:08 AM

	Unknown Object (File)
	Thu, Jan 16, 12:48 AM

	Unknown Object (File)
	Sun, Jan 12, 11:39 AM

	Unknown Object (File)
	Sun, Jan 12, 11:38 AM

	Unknown Object (File)
	Sun, Jan 12, 11:35 AM

	Unknown Object (File)
	Sun, Jan 12, 11:30 AM

	Unknown Object (File)
	Sun, Jan 12, 11:27 AM

	Unknown Object (File)
	Sun, Jan 12, 11:26 AM

Subscribers

Details

Reviewers

Commits

rCOMM35fa0b5b9686: Revert "Place call to completionHandler outside rescinding callback so that we…
rCOMMc591f0b688cd: change thread operations utilities paths in XCode so that they can be debugged

Summary

When I started to work on ENG-1398 (https://linear.app/comm/issue/ENG-1398/ios-build-136-repeatedly-crashing) I wanted to add some breakpoints in ThreadOperations.cpp. However I noticed that after landind diffs that introduced MessageOperationsUtilities, this file stopped being visible from XCode. So I deleted it and add it once again. This time XCode correctly sees the file and breakpoint insertion is possible.

Test Plan

Check that we cannot see ThreadOperations.{h, cpp} in XCode on master branch, but we can see those files after patching this diff. Ensure that app compiles and we can debug those files

Diff Detail

Repository

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

marcin created this revision.Jul 19 2022, 2:40 AM

Herald added subscribers: • abosh, atul, • adrian, ashoat. · View Herald TranscriptJul 19 2022, 2:40 AM

Insert link to differential in commit message

Harbormaster completed remote builds in B10627: Diff 14620.Jul 19 2022, 2:53 AM

Harbormaster completed remote builds in B10628: Diff 14621.Jul 19 2022, 2:55 AM

marcin requested review of this revision.Jul 19 2022, 2:55 AM

tomek accepted this revision.Jul 19 2022, 3:07 AM

This revision is now accepted and ready to land.Jul 19 2022, 3:07 AM

marcin added a child revision: D4573: Place call to completionHandler outside rescinding callback so that we avoid app being killed by the system.Jul 19 2022, 5:39 AM

Rebase master before landing

This revision was landed with ongoing or failed builds.Jul 19 2022, 10:01 AM

Closed by commit rCOMMc591f0b688cd: change thread operations utilities paths in XCode so that they can be debugged (authored by marcin). · Explain Why

This revision was automatically updated to reflect the committed changes.

marcin added a commit: rCOMMc591f0b688cd: change thread operations utilities paths in XCode so that they can be debugged.

Harbormaster completed remote builds in B10650: Diff 14650.Jul 19 2022, 10:05 AM

marcin added a commit: rCOMM35fa0b5b9686: Revert "Place call to completionHandler outside rescinding callback so that we….Jul 19 2022, 11:18 AM

marcin edited child revisions, added: D4576: use dispatch on main queue; removed: D4573: Place call to completionHandler outside rescinding callback so that we avoid app being killed by the system.Jul 19 2022, 11:31 AM

Revision Contents
Changeset List

Path

Size

native/

ios/

Comm.xcodeproj/

project.pbxproj

24 lines

Diff 14653

native/ios/Comm.xcodeproj/project.pbxproj

Loading...