[services] add public key and username fields to .proto file
ClosedPublic
Actions

Authored by varun on Jul 22 2022, 12:32 PM.

Details

Reviewers

ashoat
tomek
• karol
• max

Commits

rCOMM419e51b6abce: [services] add public key and username fields to .proto file

Summary

The identity service maintains a mapping from userID → [user_info, public_key], and also user_info → userID. user_info is a username for password auth and a wallet address for wallet auth. The public_key is used to log users into keyservers. Users should send the public_key as part of PAKE registration or Wallet login.

Note: We already get the wallet address in the siweMessage as part of the WalletLoginRequest

Test Plan

Checked syntax with linter, identity service build succeeded

Diff Detail

Repository

rCOMM Comm

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

varun created this revision.Jul 22 2022, 12:32 PM

Herald added subscribers: • abosh, atul, • adrian. · View Herald TranscriptJul 22 2022, 12:32 PM

Harbormaster completed remote builds in B10780: Diff 14821.Jul 22 2022, 12:44 PM

varun requested review of this revision.Jul 22 2022, 12:44 PM

varun added a child revision: D4614: [services] add GetUserID RPC.Jul 22 2022, 1:19 PM

remove extra line

Harbormaster completed remote builds in B10783: Diff 14824.Jul 22 2022, 2:03 PM

ashoat accepted this revision.Jul 25 2022, 5:55 AM

ashoat added inline comments.

native/cpp/CommonCpp/grpc/protos/identity.proto
66 ↗	(On Diff #14824)	ENS names are the equivalent of a username in the wallet case, but it makes sense that we're not returning an ENS name here... we should have individual clients query this info from Alchemy. At some point it might be worth considering a better UX for when a wallet without an ENS name logs in, but out of scope for now

tomek accepted this revision.Jul 25 2022, 8:35 AM

This revision is now accepted and ready to land.Jul 25 2022, 8:35 AM

Closed by commit rCOMM419e51b6abce: [services] add public key and username fields to .proto file (authored by varun). · Explain WhyJul 25 2022, 10:41 AM

This revision was automatically updated to reflect the committed changes.

varun added a commit: rCOMM419e51b6abce: [services] add public key and username fields to .proto file.

Revision Contents
Changeset List

Path

Size

native/

cpp/

CommonCpp/

grpc/

protos/

identity.proto

3 lines

Diff 14876

View Options

native/cpp/CommonCpp/grpc/protos/identity.proto

Show First 20 Lines • Show All 55 Lines • ▼ Show 20 Lines	networks:
- services-net		- services-net
build:		build:
dockerfile: services/identity/Dockerfile		dockerfile: services/identity/Dockerfile
context: ../		context: ../
image: commapp/identity-server:0.1		image: commapp/identity-server:0.1
container_name: identity-server		container_name: identity-server
ports:		ports:
- "${COMM_SERVICES_PORT_IDENTITY}:50051"		- "${COMM_SERVICES_PORT_IDENTITY}:50051"
		# localstack
		localstack:
		image: localstack/localstack
		container_name: localstack
		hostname: localstack
		ports:
		- "4566:4566"
		environment:
		- SERVICES=s3,dynamodb
		- DATA_DIR=${TMPDIR}/localstack/data
		- HOSTNAME_EXTERNAL=localstack
		volumes:
		jimUnsubmitted Not Done Inline Actions Why bind mount a temp directory instead of using a data volume? It's just gonna create issues with permissions. Also ${TMPDIR} is not used to refer to a path in both the host and the container which is a bad idea. jim: Why bind mount a temp directory instead of using a data volume? It's just gonna create issues…
		- ${TMPDIR}:/tmp/localstack
		networks:
		- services-net

[services] add public key and username fields to .proto fileClosedPublicActions