Page MenuHomePhabricator
Differential D4617

Introduce length() method in apn.Notification flow-typed
ClosedPublic
Actions

Authored by marcin on Jul 25 2022, 6:20 AM.
Tags
None
Referenced Files
Unknown Object (File)
Sat, Jul 6, 8:52 AM
Unknown Object (File)
Sat, Jul 6, 8:51 AM
Unknown Object (File)
Sat, Jul 6, 8:49 AM
Unknown Object (File)
Sat, Jul 6, 8:47 AM
Unknown Object (File)
Sat, Jul 6, 1:13 AM
Unknown Object (File)
Fri, Jul 5, 11:02 AM
Unknown Object (File)
Fri, Jul 5, 9:47 AM
Unknown Object (File)
Tue, Jul 2, 10:43 PM
View All Files
Subscribers
• abosh
• adrian
ashoat
atul

Details

Reviewers
tomek
Commits
rCOMM3c161e10a4ec: Introduce length() method in apn.Notification flow-typed
Summary

This diff extends apn.Notification type with length method provided by untyped version of node-apn library. We will need in furhter diffs

Test Plan

Temporarily place call to langth() of apn.Notification instance and ensure flow type checker does not complain.

Diff Detail

Repository
rCOMM Comm
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

marcin created this revision.Jul 25 2022, 6:20 AM
Herald added subscribers: • abosh, atul, • adrian, ashoat. · View Herald TranscriptJul 25 2022, 6:20 AM
marcin updated this revision to Diff 14836.Jul 25 2022, 6:22 AM

Rebase after editin commit message

marcin added a parent revision: D4600: Introduce iOS and Android notification max size thresholds as constants.Jul 25 2022, 6:23 AM
marcin added a child revision: D4601: Remove messageInfos fileds from iOS notification if its size exceeds defined limit.
Harbormaster completed remote builds in B10791: Diff 14835.Jul 25 2022, 6:32 AM
Harbormaster completed remote builds in B10792: Diff 14836.Jul 25 2022, 6:34 AM
marcin requested review of this revision.Jul 25 2022, 6:34 AM
tomek accepted this revision.Jul 25 2022, 8:52 AM
This revision is now accepted and ready to land.Jul 25 2022, 8:52 AM
marcin updated this revision to Diff 15269.Aug 3 2022, 8:00 AM

Rebase master before landing

Harbormaster completed remote builds in B11090: Diff 15269.Aug 3 2022, 8:13 AM
Closed by commit rCOMM3c161e10a4ec: Introduce length() method in apn.Notification flow-typed (authored by marcin). · Explain WhyAug 3 2022, 8:15 AM
This revision was automatically updated to reflect the committed changes.
marcin added a commit: rCOMM3c161e10a4ec: Introduce length() method in apn.Notification flow-typed.

Revision Contents
Changeset List

PathSize
keyserver/
flow-typed/
npm/
@parse/
1 line

Diff 15272

View Options

keyserver/flow-typed/npm/@parse/node-apn_vx.x.x.js

Loading...