Self-explanatory, these tests weren't being run on CI until now.
Depends on D4622 (even though it has higher diff ID, sorry about that)
Details
Details
Diff Detail
Diff Detail
- Repository
- rCOMM Comm
- Lint
Lint Not Applicable - Unit
Tests Not Applicable
Event Timeline
Comment Actions
Limiting to just GitHub Actions for now so we don't put twice as much pressure on the macOS agents without much benefit in return.
This is basically taken from .github/ios_ci.yml with the xcodebuild command swapped out from archive to test.
Obviously it would be nice to include this in Buildkite, but I think we should defer that until we have a more scalable way to handle CI workflows that require macOS agents. (As an aside, I looked at the Xcode Cloud API docs https://developer.apple.com/xcode-cloud/ and it seems like it should be possible to integrate with Harbormaster and/or Buildkite... but that's for way later in the future.)
Comment Actions
2 questions
do we care about line length here?
should we clean up the AUTH_KEY.p8 file?
Comment Actions
should we clean up the AUTH_KEY.p8 file?
The machine is destroyed after the workflow is created, so there's no need.
The "Clean up keychain and provisioning profile" step is actually unnecessary as well (https://docs.github.com/en/actions/deployment/deploying-xcode-applications/installing-an-apple-certificate-on-macos-runners-for-xcode-development#required-clean-up-on-self-hosted-runners). I included it "just in case" we wanted to one day run the GH Actions workflows on our own self-hosted runners... in which case adding the cleanup step would make things more portable or whatever.
But I think we're set on Buildkite for our self-hosted CI needs so it could probably just be removed at this point.