Page MenuHomePhabricator

Conditionally crash the app on getAllMessagesSync failure
AbandonedPublic

Authored by marcin on Jul 27 2022, 6:52 AM.
Tags
None
Referenced Files
Unknown Object (File)
Tue, May 14, 10:08 AM
Unknown Object (File)
Tue, May 7, 6:08 PM
Unknown Object (File)
Mon, Apr 29, 5:37 AM
Unknown Object (File)
Sun, Apr 21, 12:30 PM
Unknown Object (File)
Sun, Apr 21, 12:29 PM
Unknown Object (File)
Sun, Apr 21, 12:27 PM
Unknown Object (File)
Apr 13 2024, 11:22 AM
Unknown Object (File)
Apr 13 2024, 5:45 AM

Details

Reviewers
tomek
atul
ashoat
Summary

This differential conditionally crashes application with temporary changes for staff release 137 if the user is staff member and crash reports are enabled. Otherwise application will continue to work

Test Plan

Firstly repeat steps from parent diff test plan. Then experiment with different users and privacy settings to see that it afffects whether application crashes or not.

Diff Detail

Repository
rCOMM Comm
Branch
marcin/eng-1449
Lint
No Lint Coverage
Unit
No Test Coverage

Event Timeline

ashoat added 1 blocking reviewer(s): atul.

Looks great to me, but would be great if @atul could take a look since he wrote this logic.

For context, reviewers can check ENG-1444 and ENG-1449.

native/redux/redux-setup.js
327

I think it's cleaner to use the same indexing syntax throughout

One think to note here. Changes above are dependent on the commit @atul made: https://github.com/CommE2E/comm/commit/a04a84f3a156c218dd778a5f9d0905d2abf9910b. Currently master does not include those changes since they were reverted here: https://github.com/CommE2E/comm/commit/63233aa3f2f12801a07f96ff999761dab7aa346b. I locally cherry-picked the first one to implement and test those features. This is the first time I am dealing with diffs this way so I am not sure what is going to happen if I try landing and how we should approach that.

That's interesting. We should probably get @atul's opinion on this... probably he has this change locally, and will need to update his local patch. I'm guessing we won't be able to "land" this like we do normally (arc land, which does git push to master) but we can manually "Close" it once we're done.

That's interesting. We should probably get @atul's opinion on this... probably he has this change locally, and will need to update his local patch. I'm guessing we won't be able to "land" this like we do normally (arc land, which does git push to master) but we can manually "Close" it once we're done.

Yeah I have a local patch that I've been applying when making releases that adds this Redux/SQLite equality check.

Now that these changes have been "approved, "I can update my patch to include these changes and make a release... does that seem like a reasonable approach?

Yeah that makes sense to me, if the changes look good to you!

tomek added inline comments.
native/redux/redux-setup.js
328

This looks good to me, will kick off build 138 momentarily.

Not sure how this fits into our usual Phabricator workflow, but here's the patch for build 138 release with your changes in this diff included (with some of the feedback from @tomek) addressed): https://github.com/CommE2E/comm/commit/95859fcd982286539d2d267f57b63ed07d2d2965

This revision is now accepted and ready to land.Jul 28 2022, 10:25 AM

Are we still using this patch in staff releases?