Paths

Table of Contentst

Differential D4657

[services] new DB client method to get userID for a given username
ClosedPublic
Actions

Authored by varun on Jul 27 2022, 2:05 PM.

Tags

None

Referenced Files

	Unknown Object (File)
	Tue, Nov 5, 6:57 PM

	Unknown Object (File)
	Tue, Nov 5, 6:46 PM

	Unknown Object (File)
	Tue, Nov 5, 5:33 PM

	Unknown Object (File)
	Sun, Oct 27, 6:19 PM

	Unknown Object (File)
	Sun, Oct 27, 6:19 PM

	Unknown Object (File)
	Sun, Oct 27, 6:19 PM

	Unknown Object (File)
	Sun, Oct 27, 6:19 PM

	Unknown Object (File)
	Sun, Oct 27, 6:16 PM

Subscribers

Details

Reviewers

tomek
• karol

Commits

rCOMMb144a210c58d: [services] new DB client method to get userID for a given username

Summary

Using the username-index on the identity-users table, query for an item with the given username and return the corresponding userID

Depends on D4656

Test Plan

used client method to return a userID from DDB

Diff Detail

Repository

Branch

identity (branched from master)

Lint

No Lint Coverage

Unit

No Test Coverage

Event Timeline

varun created this revision.Jul 27 2022, 2:05 PM

Herald added subscribers: • abosh, atul, • adrian, ashoat. · View Herald TranscriptJul 27 2022, 2:05 PM

Harbormaster completed remote builds in B10920: Diff 15026.Jul 27 2022, 2:19 PM

varun requested review of this revision.Jul 27 2022, 2:19 PM

Extend the method to work for look up by wallet address too

Harbormaster completed remote builds in B10921: Diff 15027.Jul 27 2022, 2:46 PM

varun added a child revision: D4658: [services] implement getUserID rpc.Jul 27 2022, 2:52 PM

tomek accepted this revision.Jul 28 2022, 2:43 AM

tomek added inline comments.

services/identity/src/database.rs
235–242 ↗	(On Diff #15027)	I don't think that using `if` is a good idea here as the compiler doesn't enforce that all the enums are used. This is a big issue if we ever decide to introduce new AuthType. We should use match instead.
258 ↗	(On Diff #15027)	Maybe `== 0`?
267 ↗	(On Diff #15027)	Why do we remove here?

This revision is now accepted and ready to land.Jul 28 2022, 2:43 AM

varun added inline comments.Jul 28 2022, 11:38 AM

services/identity/src/database.rs
235–242 ↗	(On Diff #15027)	good point
258 ↗	(On Diff #15027)	sure
267 ↗	(On Diff #15027)	`get()` only gives us a reference to the `AttributeValue`, whereas `remove` is owned

Closed by commit rCOMMb144a210c58d: [services] new DB client method to get userID for a given username (authored by varun). · Explain WhyJul 28 2022, 12:49 PM

This revision was automatically updated to reflect the committed changes.

varun added a commit: rCOMMb144a210c58d: [services] new DB client method to get userID for a given username.

Revision Contents
Changeset List

Path

Size

services/

identity/

src/

55 lines

Diff 15026

services/identity/src/database.rs

Loading...