[services] implement getUserID rpc
ClosedPublic
Actions

Authored by varun on Jul 27 2022, 2:52 PM.

Details

Reviewers

tomek
• karol

Commits

rCOMMb097b3dcdd6d: [services] implement getUserID rpc

Summary

This RPC lets a client get a user ID corresponding to a given wallet address or username.

Depends on D4657

Test Plan

Ran the service and called the RPC, retrieved the correct user ID from DynamoDB with a wallet address and a username

Repository

rCOMM Comm

Branch

identity (branched from master)

Lint

No Lint Coverage

Unit

No Test Coverage

varun edited the test plan for this revision. (Show Details)Jul 27 2022, 2:53 PM

varun requested review of this revision.Jul 27 2022, 3:05 PM

tomek added inline comments.

services/identity/src/service.rs
360 ↗	(On Diff #15028)	Wondering if we should log this request. Can it contain sensitive data?
380–391 ↗	(On Diff #15028)	This code is duplicated. Is there a way to extract common logic from it?

This revision is now accepted and ready to land.Jul 28 2022, 3:00 AM

services/identity/src/service.rs
360 ↗	(On Diff #15028)	We should avoid logging things like user IDs
360 ↗	(On Diff #15028)	More context: https://phab.comm.dev/D4652#133661

services/identity/src/service.rs
360 ↗	(On Diff #15028)	ok, will remove this and similar logs
380–391 ↗	(On Diff #15028)	yeah we can have a function that handles matching errors, i'll try to implement that