[lib] Introduce shared `getRelationshipActionText` function
ClosedPublic
Actions

Authored by • jacek on Jul 29 2022, 3:00 AM.

Details

Reviewers

tomek
atul

Commits

rCOMM8aec1c68e78f: [lib] Introduce shared `getRelationshipActionText` function

Summary

Moved part of the logic responsible for selecting correct text to relationship action button to lib, so it could be reused on web

Test Plan

Confirm mobile app relationship buttons in thread settings still contain correct text

Diff Detail

Repository

rCOMM Comm

Lint

No Lint Coverage

Unit

No Test Coverage

Event Timeline

• jacek created this revision.Jul 29 2022, 3:00 AM

Herald added subscribers: • abosh, • adrian, ashoat. · View Herald TranscriptJul 29 2022, 3:00 AM

Harbormaster completed remote builds in B10967: Diff 15089.Jul 29 2022, 3:12 AM

• jacek requested review of this revision.Jul 29 2022, 3:12 AM

• jacek added a child revision: D4679: [web] Introduce `ThreadSettingsRelationshipButton` component.Jul 29 2022, 3:27 AM

tomek accepted this revision.Jul 29 2022, 5:26 AM

This revision is now accepted and ready to land.Jul 29 2022, 5:26 AM

Closed by commit rCOMM8aec1c68e78f: [lib] Introduce shared `getRelationshipActionText` function (authored by • jacek). · Explain WhyAug 3 2022, 4:27 AM

This revision was automatically updated to reflect the committed changes.

• jacek added a commit: rCOMM8aec1c68e78f: [lib] Introduce shared `getRelationshipActionText` function.

Revision Contents
Changeset List

Path

Size

lib/

shared/

relationship-utils.js

25 lines

native/

chat/

settings/

thread-settings-edit-relationship.react.js

27 lines

Diff 15089

View Options

lib/shared/relationship-utils.js