[web] Include `Relationship` tab in thread settings modal
ClosedPublic
Actions

Authored by • jacek on Jul 29 2022, 3:23 AM.

Details

Reviewers

tomek
atul
ashoat

Commits

rCOMMd6a365cf5e30: [web] Include `Relationship` tab in thread settings modal

Summary

Display relationship tab in thread settings modal if there are some relationship actions available.
It modifies size of the modal so it has now the same size in every tab - as we discussed it already with Ashoat.

Screenshot_Google Chrome_2022-07-29_122412.png (665×460 px, 25 KB)

Test Plan

In personal threads additional tab "Relationship" should appear in thread settings modal. The actions should be exactly the same as in mobile app.

Diff Detail

Repository

rCOMM Comm

Lint

No Lint Coverage

Unit

No Test Coverage

Event Timeline

• jacek created this revision.Jul 29 2022, 3:23 AM

Herald added subscribers: • abosh, • adrian, ashoat. · View Herald TranscriptJul 29 2022, 3:23 AM

• jacek edited the summary of this revision. (Show Details)Jul 29 2022, 3:24 AM

• jacek added a parent revision: D4680: [web] Introduce `ThreadSettingsRelationshipTab` component.

Harbormaster completed remote builds in B10970: Diff 15092.Jul 29 2022, 3:36 AM

• jacek requested review of this revision.Jul 29 2022, 3:36 AM

Adding @ashoat because this diff adds new UI (and a tiny bit of copy).

web/modals/threads/settings/thread-settings-modal.react.js
35 ↗	(On Diff #15092)	How does it look like when all four tabs are available?
179 ↗	(On Diff #15092)	I guess that `&& otherUserInfo` was added to satisfy Flow, because `availableRelationshipActions` is always empty when `!otherUserInfo`.