[keyserver] Clean up `setup.sh` using ShellCheck
AbandonedPublic
Actions

Authored by • abosh on Aug 2 2022, 9:14 AM.

Details

Reviewers

atul
• jon
tomek
ashoat

Summary

Related Linear issue here. This is part of a set of diffs that will allow ShellCheck to be added to the CI. See inline comments for specific details of the ShellCheck error/warning output.

Not even sure if this script is used anywhere, since I searched the entire codebase and didn't find a usage of setup.sh. But it's blocking adding ShellCheck to the CI, so it was updated.

Test Plan

ShellCheck

Diff Detail

Repository

rCOMM Comm

Branch

master

Lint

No Lint Coverage

Unit

No Test Coverage

Event Timeline

• abosh created this revision.Aug 2 2022, 9:14 AM

Herald added a subscriber: • adrian. · View Herald TranscriptAug 2 2022, 9:14 AM

• abosh retitled this revision from [web] Clean up `setup.sh` using ShellCheck to [keyserver] Clean up `setup.sh` using ShellCheck.Aug 2 2022, 9:15 AM

• abosh added inline comments.

keyserver/bash/setup.sh
8–9	Can't follow non-constant source. Use a directive to specify location.

• abosh edited the test plan for this revision. (Show Details)Aug 2 2022, 9:18 AM

• abosh edited the test plan for this revision. (Show Details)

Harbormaster completed remote builds in B11056: Diff 15218.Aug 2 2022, 9:27 AM

• abosh requested review of this revision.Aug 2 2022, 9:27 AM

Cool, looks like the same deal as run-prod.sh

This revision is now accepted and ready to land.Aug 2 2022, 10:30 AM

• abosh edited the summary of this revision. (Show Details)Aug 2 2022, 10:46 AM

I don't think we use this script anymore. I think it was only used in deploy.sh, which was deleted in D4484. I don't see any results with git grep setup.sh, anyways.

I think we can just delete it

This revision now requires changes to proceed.Aug 2 2022, 11:04 AM

• abosh mentioned this in D4726: [keyserver] Delete `setup.sh`.Aug 2 2022, 2:29 PM

In D4714#135639, @ashoat wrote:

I don't think we use this script anymore. I think it was only used in deploy.sh, which was deleted in D4484. I don't see any results with git grep setup.sh, anyways.

I think we can just delete it

Ok! Abandoning this, deleted setup.sh in D4726.

• abosh mentioned this in rCOMMec1b0cdf22a0: [keyserver] Delete `setup.sh`.Aug 3 2022, 8:35 AM