Paths

Table of Contentst

Differential D4720

[services] Clean up `build_sources.sh` using ShellCheck
ClosedPublic
Actions

Authored by • abosh on Aug 2 2022, 10:02 AM.

Tags

None

Referenced Files

	F2175196: D4720.id15228.diff
	Wed, Jul 3, 2:09 AM

	F2175074: D4720.diff
	Wed, Jul 3, 1:53 AM

	Unknown Object (File)
	Sun, Jun 30, 6:18 PM

	Unknown Object (File)
	Fri, Jun 21, 4:06 PM

	Unknown Object (File)
	Fri, Jun 21, 4:06 PM

	Unknown Object (File)
	Fri, Jun 21, 4:05 PM

	Unknown Object (File)
	Fri, Jun 21, 3:54 PM

	Unknown Object (File)
	Tue, Jun 11, 9:47 PM

View All 42 Files

Subscribers

Details

Reviewers

atul
• jon
tomek
ashoat

Commits

rCOMM4ff2d64d1f10: [services] Clean up `build_sources.sh` using ShellCheck

Summary

Related Linear issue here. This is part of a set of diffs that will allow ShellCheck to be added to the CI. See inline comments for specific details of the ShellCheck error/warning output.

Test Plan

Additionally, this script is run by build_service.sh, which is run during the Backup, Blob, and Tunnelbroker builds so if those workflows continue to pass CI we can reasonably assume that the script continues to work as expected.

Diff Detail

Repository

Branch

master

Lint

No Lint Coverage

Unit

No Test Coverage

Event Timeline

• abosh created this revision.Aug 2 2022, 10:02 AM

Herald added subscribers: • karol, • adrian. · View Herald TranscriptAug 2 2022, 10:02 AM

• abosh added inline comments.Aug 2 2022, 10:03 AM

services/lib/docker/build_sources.sh
16	Double quote to prevent globbing and word splitting.

Harbormaster completed remote builds in B11063: Diff 15228.Aug 2 2022, 10:15 AM

• abosh requested review of this revision.Aug 2 2022, 10:15 AM

• abosh edited the test plan for this revision. (Show Details)Aug 2 2022, 10:51 AM

I don't have much context on this script I think, and I'm a bad choice for a first-pass reviewer except for cases listed here

• jon accepted this revision.Aug 2 2022, 11:54 AM

This revision is now accepted and ready to land.Aug 2 2022, 11:54 AM

atul accepted this revision.Aug 2 2022, 11:58 AM

Closed by commit rCOMM4ff2d64d1f10: [services] Clean up `build_sources.sh` using ShellCheck (authored by • abosh). · Explain WhyAug 2 2022, 2:23 PM

This revision was automatically updated to reflect the committed changes.

• abosh added a commit: rCOMM4ff2d64d1f10: [services] Clean up `build_sources.sh` using ShellCheck.

Revision Contents
Changeset List

Path

Size

services/

lib/

docker/

build_sources.sh

2 lines

Diff 15228

services/lib/docker/build_sources.sh

Loading...