[native] create Client struct and add method for get_user_id
ClosedPublic
Actions

Authored by varun on Aug 3 2022, 10:44 AM.

Details

Reviewers

tomek
• karol
• max

Commits

rCOMM0735ad75abbd: [native] create Client struct and add method for get_user_id

Summary

The two new functions are small enough that I've included them in the same diff. We construct a Client that holds an identity_client and then use the identity_client to call the GetUserID rpc

Test Plan

cargo build (will test more thoroughly once library is integrated into application)

Diff Detail

Repository

rCOMM Comm

Branch

identity-client

Lint

No Lint Coverage

Unit

No Test Coverage

Event Timeline

varun created this revision.Aug 3 2022, 10:44 AM

Herald added subscribers: • abosh, atul, • adrian, ashoat. · View Herald TranscriptAug 3 2022, 10:44 AM

Harbormaster completed remote builds in B11094: Diff 15282.Aug 3 2022, 10:57 AM

varun requested review of this revision.Aug 3 2022, 10:57 AM

tomek accepted this revision.Aug 4 2022, 2:52 AM

tomek added inline comments.

native/cpp/CommonCpp/grpc/grpc_client/src/lib.rs
15	We probably should introduce some kind of config to hold addresses.

This revision is now accepted and ready to land.Aug 4 2022, 2:52 AM

Closed by commit rCOMM0735ad75abbd: [native] create Client struct and add method for get_user_id (authored by varun). · Explain WhyAug 4 2022, 12:08 PM

This revision was automatically updated to reflect the committed changes.

varun added a commit: rCOMM0735ad75abbd: [native] create Client struct and add method for get_user_id.

Revision Contents
Changeset List

Path

Size

native/

cpp/

CommonCpp/

grpc/

grpc_client/

src/

lib.rs

39 lines

Diff 15282

View Options

native/cpp/CommonCpp/grpc/grpc_client/src/lib.rs

[native] create Client struct and add method for get_user_idClosedPublicActions