[services] Tunnelbroker - Fix `amqpReady` assignment
ClosedPublic
Actions

Authored by • max on Aug 4 2022, 11:09 AM.

Details

Reviewers

• karol
tomek

Commits

rCOMM6b6d2067a16f: [services] Tunnelbroker - Fix `amqpReady` assignment

Summary

This diff is a part of the stack.

The private variable amqpReady in AmqpManager reflects the state of the AMQP Client connection state.
To update the state we must use only two callbacks:

This diff introduces assignments on OnReady() and removes the unneeded assignments.

Related linear task: ENG-1495

Test Plan

Successfully built using yarn run-tunnelbroker-service-in-sandbox command.
Passing all AMQP unit tests in the last diff D4749 in a stack.

Diff Detail

Repository

rCOMM Comm

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

• max created this revision.Aug 4 2022, 11:09 AM

• max held this revision as a draft.

Herald added subscribers: • abosh, • karol, atul and 3 others. · View Herald TranscriptAug 4 2022, 11:09 AM

• max edited the summary of this revision. (Show Details)Aug 4 2022, 11:14 AM

• max edited the test plan for this revision. (Show Details)

• max added reviewers: • karol, tomek.

• max added parent revisions: D4741: [services] Tunnelbroker - Add `waitUntilReady` function in AmqpManager, D4740: [services] Tunnelbroker - Wrap `connect()` into `init()` in AmqpManager.

• max added inline comments.Aug 4 2022, 11:17 AM

services/tunnelbroker/src/Amqp/AmqpManager.cpp
69 ↗	(On Diff #15327)	This is handled by `this->amqpChannel->onError` from above and we don't need it.
71 ↗	(On Diff #15327)	This is handled by introducing `this->amqpChannel->onReady` in this diff and we should remove it from here.