Page MenuHomePhabricator

[services] Tunnelbroker - Refactor handler names in Amqp `connectInternal()`
ClosedPublic

Authored by max on Aug 4 2022, 11:18 AM.
Tags
None
Referenced Files
F5899598: D4743.id15825.diff
Thu, Apr 17, 12:08 PM
F5894214: D4743.id15822.diff
Thu, Apr 17, 10:09 AM
F5891238: D4743.id15328.diff
Thu, Apr 17, 7:07 AM
F5891160: D4743.id15401.diff
Thu, Apr 17, 7:04 AM
F5875334: D4743.id15407.diff
Thu, Apr 17, 12:31 AM
F5873470: D4743.id15407.diff
Wed, Apr 16, 10:53 PM
F5873077: D4743.id.diff
Wed, Apr 16, 10:31 PM
Unknown Object (File)
Wed, Apr 16, 11:59 AM

Details

Summary

This diff is a part of the stack.

Introducing refactoring to the handler variable names in AmqpManager -> connectInternal() method to reflect its purposes instead of using the shorthand.

Related linear task: ENG-1495

Test Plan

Successfully built using yarn run-tunnelbroker-service-in-sandbox command.
Passing all AMQP unit tests in the last diff D4749 in a stack.

Diff Detail

Repository
rCOMM Comm
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

max held this revision as a draft.
max edited the test plan for this revision. (Show Details)
max added reviewers: karol, tomek.
max published this revision for review.Aug 4 2022, 4:52 PM
max edited the test plan for this revision. (Show Details)
This revision is now accepted and ready to land.Aug 9 2022, 9:29 AM

Rebase/merge on master changes.

This revision was landed with ongoing or failed builds.Aug 22 2022, 7:12 AM
This revision was automatically updated to reflect the committed changes.