Page MenuHomePhabricator
Differential D4743

[services] Tunnelbroker - Refactor handler names in Amqp `connectInternal()`
ClosedPublic
Actions

Authored by • max on Aug 4 2022, 11:18 AM.
Tags
None
Referenced Files
F3350002: D4743.diff
Fri, Nov 22, 8:13 PM
Unknown Object (File)
Sun, Oct 27, 4:34 AM
Unknown Object (File)
Sun, Oct 27, 4:34 AM
Unknown Object (File)
Sun, Oct 27, 4:34 AM
Unknown Object (File)
Sun, Oct 27, 4:34 AM
Unknown Object (File)
Sun, Oct 27, 4:34 AM
Unknown Object (File)
Sun, Oct 27, 4:34 AM
Unknown Object (File)
Sun, Oct 27, 4:32 AM
View All Files
Subscribers
• abosh
• adrian
ashoat
atul
• karol
tomek

Details

Reviewers
• karol
tomek
Commits
rCOMM31bec4fa28ef: [services] Tunnelbroker - Refactor handler names in Amqp `connectInternal()`
Summary

This diff is a part of the stack.

Introducing refactoring to the handler variable names in AmqpManager -> connectInternal() method to reflect its purposes instead of using the shorthand.

Related linear task: ENG-1495

Test Plan

Successfully built using yarn run-tunnelbroker-service-in-sandbox command.
Passing all AMQP unit tests in the last diff D4749 in a stack.

Diff Detail

Repository
rCOMM Comm
Branch
D4743
Lint
No Lint Coverage
Unit
No Test Coverage

Event Timeline

• max created this revision.Aug 4 2022, 11:18 AM
• max held this revision as a draft.
Herald added subscribers: • abosh, • karol, atul and 3 others. · View Herald TranscriptAug 4 2022, 11:18 AM
• max added parent revisions: D4742: [services] Tunnelbroker - Fix `amqpReady` assignment, D4741: [services] Tunnelbroker - Add `waitUntilReady` function in AmqpManager, D4740: [services] Tunnelbroker - Wrap `connect()` into `init()` in AmqpManager.Aug 4 2022, 11:19 AM
• max edited the summary of this revision. (Show Details)Aug 4 2022, 11:22 AM
• max edited the test plan for this revision. (Show Details)
• max added reviewers: • karol, tomek.
Harbormaster completed remote builds in B11131: Diff 15328.Aug 4 2022, 11:30 AM
• max added a child revision: D4744: [services] Tunnelbroker - Fix AMQP client reconnection algorithm.Aug 4 2022, 12:18 PM
• max published this revision for review.Aug 4 2022, 4:52 PM
• max edited the test plan for this revision. (Show Details)
• max updated this revision to Diff 15401.Aug 6 2022, 11:50 AM

Rebase on parent changes.

• max added a parent revision: D4767: [services] Tunnelbroker - Add AMQP shared channel locking.Aug 6 2022, 11:50 AM
Harbormaster failed remote builds in B11193: Diff 15401!Aug 6 2022, 11:51 AM
• max updated this revision to Diff 15407.Aug 6 2022, 12:43 PM

Rebase on master changes.

Harbormaster completed remote builds in B11198: Diff 15407.Aug 6 2022, 12:55 PM
• max added a child revision: D4768: [services] Tunnelbroker - Amqp Manager in parallel threads messages throughput test.Aug 6 2022, 1:06 PM
• karol accepted this revision.Aug 8 2022, 6:58 AM
tomek accepted this revision.Aug 9 2022, 9:29 AM
This revision is now accepted and ready to land.Aug 9 2022, 9:29 AM
• max updated this revision to Diff 15822.Aug 22 2022, 7:05 AM

Rebase/merge on master changes.

This revision was landed with ongoing or failed builds.Aug 22 2022, 7:12 AM
Closed by commit rCOMM31bec4fa28ef: [services] Tunnelbroker - Refactor handler names in Amqp `connectInternal()` (authored by • max). · Explain Why
This revision was automatically updated to reflect the committed changes.
• max added a commit: rCOMM31bec4fa28ef: [services] Tunnelbroker - Refactor handler names in Amqp `connectInternal()`.
Harbormaster completed remote builds in B11504: Diff 15822.Aug 22 2022, 7:16 AM
• max removed a child revision: D4768: [services] Tunnelbroker - Amqp Manager in parallel threads messages throughput test.Aug 24 2022, 5:35 AM

Revision Contents
Changeset List

PathSize
services/
tunnelbroker/
src/
Amqp/
12 lines

Diff 15822

View Options

services/tunnelbroker/src/Amqp/AmqpManager.cpp

Loading...