[Chore] Remove yarn's clang-format
AbandonedPublic
Actions

Authored by varun on Aug 9 2022, 9:53 AM.

Details

Reviewers

• abosh
ashoat
• jon
atul

Summary

With nix develop on mac, the clang package will automatically expose
this package, making the yarn package unnecessary

Test Plan

nix develop
which clang-format # should point to nix store

Diff Detail

Repository

rCOMM Comm

Branch

jonringer/clang-format

Lint

No Lint Coverage

Unit

No Test Coverage

Event Timeline

• jon created this revision.Aug 9 2022, 9:53 AM

Herald added subscribers: • adrian, tomek, ashoat. · View Herald TranscriptAug 9 2022, 9:54 AM

Looks good, but we can't land this until C++ workflows are fully migrated to Nix.

(As an alternative, we could do what we're doing with shellcheck... add it to the dev environment instructions and ask all devs to install it. But probably not worth it given we're close on C++ workflows being supported in Nix.)

Harbormaster completed remote builds in B11247: Diff 15481.Aug 9 2022, 10:06 AM

• jon requested review of this revision.Aug 9 2022, 10:06 AM

Agree with @ashoat's assessment. If you can create a stack out of this diff so the depends-on relationship between Nix migration and this is more explicit that'd be cool, but not necessary.

This revision is now accepted and ready to land.Aug 9 2022, 10:27 AM

Requesting changes to block landing based on reasoning above. See also @abosh's comment in D4779

This revision now requires changes to proceed.Aug 9 2022, 10:48 AM

Resigning to clean up queue, feel free to add back if there's something specific I can help with.

varun commandeered this revision.Jan 15 2024, 12:43 PM

varun abandoned this revision.

varun edited reviewers, added: • jon; removed: varun.

Revision Contents
Changeset List

Path

Size

package.json

1 line

Diff 15481

View Options

[Chore] Remove yarn's clang-formatAbandonedPublicActions