Update gtest usage to be more canonical
Depends on D4781
Details
Details
- Reviewers
atul • max • karol - Commits
- rCOMMaabb0e14f1af: [Services] Fix tunnelbroker ctest usage
nix develop cd services/tunnelbroker export COMM_TEST_SERVICES=1 rm -rf build mkdir build cd build cmake .. make -j ctest # test suite should run
If you want the test suite to fully pass, you need to also follow
https://github.com/CommE2E/comm/blob/master/docs/dev_services.md#rabbitmq-tunnelbroker-only
Unfortunately, the logic for finding the tunnelbroker.ini file still
assumes docker-only paths
Diff Detail
Diff Detail
- Repository
- rCOMM Comm
- Lint
Lint Not Applicable - Unit
Tests Not Applicable
Event Timeline
Comment Actions
Followed the Test Plan and confirmed that everything worked as expected!
Didn't bother setting up RabbitMQ to get all of the tests to pass, but I think the ones expected to succeed did.
| services/tunnelbroker/CMakeLists.txt | ||
|---|---|---|
| 110 ↗ | (On Diff #15485) | Is this an unrelated change, or is it connected in some way? |
| services/tunnelbroker/CMakeLists.txt | ||
|---|---|---|
| 110 ↗ | (On Diff #15485) | not directly related, I missed it in https://phab.comm.dev/D4671 |
Comment Actions
Seems that this should be fixed from the tunnelbroker side to run it in a nix:
Unfortunately, the logic for finding the tunnelbroker.ini file still assumes docker-only paths
I have created a task for it as ENG-1589.