Page MenuHomePhabricator

[native] Fix message tooltip positioning for robotext with sidebar
ClosedPublic

Authored by jacek on Aug 11 2022, 3:58 AM.
Tags
None
Referenced Files
Unknown Object (File)
Wed, May 15, 10:25 AM
Unknown Object (File)
Wed, May 15, 10:25 AM
Unknown Object (File)
Wed, May 15, 10:25 AM
Unknown Object (File)
Wed, May 15, 10:22 AM
Unknown Object (File)
Tue, May 7, 12:24 AM
Unknown Object (File)
Apr 12 2024, 10:58 AM
Unknown Object (File)
Apr 7 2024, 4:21 PM
Unknown Object (File)
Mar 14 2024, 10:22 PM

Details

Summary

The diff fixes: https://linear.app/comm/issue/ENG-1591/messagetooltip-renders-in-wrong-place-if-robotext-message-contains
It moves inlineSidebar for robotext messages one level higher in component tree, so it won't be included when measuring message position and size - like it is with composedMessage.

Test Plan

Test if toolptip displays correctly on android and iOS, confirm that animations for opening or creating sidebar modal still works as before.

Diff Detail

Repository
rCOMM Comm
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

This revision is now accepted and ready to land.Aug 11 2022, 5:37 AM

Does this have any visual effect (outside of fixing ENG-1591)?

Does this have any visual effect (outside of fixing ENG-1591)?

I didn't find any