Page MenuHomePhabricator

[native] Fix message tooltip positioning for robotext with sidebar
ClosedPublic

Authored by jacek on Aug 11 2022, 3:58 AM.
Tags
None
Referenced Files
Unknown Object (File)
Tue, Nov 26, 1:31 AM
Unknown Object (File)
Mon, Nov 25, 11:36 PM
Unknown Object (File)
Fri, Nov 22, 11:56 PM
Unknown Object (File)
Mon, Nov 18, 3:15 PM
Unknown Object (File)
Mon, Nov 11, 4:19 AM
Unknown Object (File)
Sat, Nov 9, 11:44 PM
Unknown Object (File)
Sat, Nov 9, 9:15 PM
Unknown Object (File)
Sat, Nov 9, 8:38 PM

Details

Summary

The diff fixes: https://linear.app/comm/issue/ENG-1591/messagetooltip-renders-in-wrong-place-if-robotext-message-contains
It moves inlineSidebar for robotext messages one level higher in component tree, so it won't be included when measuring message position and size - like it is with composedMessage.

Test Plan

Test if toolptip displays correctly on android and iOS, confirm that animations for opening or creating sidebar modal still works as before.

Diff Detail

Repository
rCOMM Comm
Branch
jacek/inline-sidebar
Lint
No Lint Coverage
Unit
No Test Coverage

Event Timeline

This revision is now accepted and ready to land.Aug 11 2022, 5:37 AM

Does this have any visual effect (outside of fixing ENG-1591)?

Does this have any visual effect (outside of fixing ENG-1591)?

I didn't find any